Refactor / Rewrite #153
Merged
Refactor / Rewrite #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p to setup.py compile.
…include:
- Use the Standard Template Library instead of home-grown containers.
- Make the code more object-oriented (convert free functions into
class methods where appropriate).
- Use smart pointers and good RAII design to avoid memory leaks and
access to uninitialized memory.
- Expose C++ classes and most public methods in the python bindings.
- Functions for doing I/O and visualization are in python.
- Add sphinx documentation, setup.py unit test runner, etc.
- Code has timer and logging class in the C++ layer (and exposed to python)
which support DESI_LOGLEVEL.
Still To-Do:
- Enable travis tests.
- Update positioner geometry to match reality.
- Documentation is lacking for many functions.
- Restore reading of ECSV state file.
- Implement exclusion zone at petal boundaries.
- Propagate GFA information into final merged files.
…with clang. Will fix that later.
…ly count target types assigned when a target is more than one type.
…n output. Fix tile selection in load_tiles().
…ly. Also add option to control threading of vectorized RA/DEC to X/Y project, needed when mixing OpenMP with multiprocessing.
allow user to override sciencemask, stdmask, etc.
update --targets option; add bin/fiberassign
support NUMOBS_INIT and PRIORITY_INIT
…files that was producing plotting errors.
…er assignment to the output. When reading FITS results from raw and merged formats, ensure that the combined POS + ETC table data is consistent.
…onitor target data when reading merged files.
…into tsk_refactor
…rate the docs. Add our requirements for pip and remove the mocks.
…into tsk_refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR for more testing. It has diverged from master, but will deal with merging later. See documentation for install instructions and examples. There are quite a few known issues (see most recent commit message).