Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API #29

Merged
merged 69 commits into from
Feb 20, 2016
Merged

Update API #29

merged 69 commits into from
Feb 20, 2016

Conversation

dkirkby
Copy link
Member

@dkirkby dkirkby commented Feb 18, 2016

This version introduces some significant API changes in order to make the
code instrument agnostic and facilitate future algorithm improvements.
There are no changes yet to the underlying algorithms and assumptions, so
results using the new desi.yaml config should be identical to v0.2.

@dkirkby
Add speclite dependency
83b3555
@dkirkby
Install speclite with pip instead of conda in travis config
f31d779
@dkirkby
reformat atmosphere module for pep8 and numpy-style docstrings
b965df4
@dkirkby
Add load() method using astropy.table to read data files
85b5500
@dkirkby
Remove np.loadtxt() data file reader
389f97d
@dkirkby
Use load() for FITS throughput files
a31e768
@dkirkby
Use load() to reach each column of psf-quicksim.fits
f753368
@dkirkby
Update changelog
2e23ce8
@dkirkby
Read yaml config file in driver
434abfa
@dkirkby
Add config module to manage config options
0f9377e
@dkirkby
Configure atmosphere model from YAML
c2d8dc1
@dkirkby
Implement Configuration.load_table for flexible input of arbitrary ta…
4823ac1 
…bulated data
@dkirkby
Initialize instrument model from config
00c95c6
@dkirkby
Regression test now working entirely from config
2d848f5
@dkirkby
Put desi.yaml into data/config/ and update load_config() to look there
2740f41
@dkirkby
Start a test config for regression tests
fa2270f
@dkirkby
Implement base_path: <PACKAGE_DATA> to read from data/
1f48f6d
@dkirkby
Remove unused fwhm_spatial from psf table
0973a81
@dkirkby
Add placeholder unit test files
584baba
@dkirkby
Migrate calculations into Instrument class
86f0871
@dkirkby
Treat u.pixel as a linear unit
fab1c6f
@dkirkby
Move more calculations into instrument module and add plot() method
b2e0ea9
@dkirkby
Add Atmosphere.plot() method
73d3c17
@dkirkby
Sort out factors of 1e-17
82958ba
@dkirkby
Remove all desimodel inputs from test config
f23c80b
@dkirkby
Update test input docs
d321da1
@dkirkby
Remove unused sources module
b30a979
@dkirkby
Start new source module
9312840
@dkirkby
Initialize source from config
e226ccd
@dkirkby
Initialize simulator from config
1a13319
@dkirkby dkirkby mentioned this pull request Feb 18, 2016
Merged
@dkirkby
Update plot() methods
5582143
@dkirkby
Work on updating docs
37237f7
@dkirkby
Update config docs
923d5e2
@dkirkby
Update docs
bba36fb
@dkirkby
More doc updates
73859dd
@dkirkby
Add end-to-end unit test using test config
61ae217
@dkirkby
Propagate camera gain but keep results in electrons
47434ed
@dkirkby
Overhaul source module
6132f8a
@dkirkby
Add missing doc images
a7f6764
@dkirkby
Do not use assume_sorted with scipy.interpolate.interp1d since it is …
e550255 
…not present in numpy < 1.8
@dkirkby
Add unit tests for source module
70ccf19
@dkirkby
Make z_in,z_out,filter_name,ab_magnitude required source config params
5fd1a48
@dkirkby
Restore source redshift, normalization cmd-line args
bbfe227
@dkirkby
pep8-ify driver module
9696292
@dkirkby
Move compatibility recipes to new history doc page
bcbda1f
@dkirkby
Disable travis test with numpy < 1.8 (needs speclite update)
d5cabbb
@dkirkby
Purge __init__
936a6b1
@dkirkby
Make source a property of simulator instead of an arg to simulate()
35850fb
@dkirkby
Rename source.ab_magnitude to source.ab_magnitude_out for consistency
228e503
@dkirkby
Write some API intro docs
03e6bea
@dkirkby
Copy link
Member Author

dkirkby commented Feb 20, 2016

Any objections to merging this PR now?

dkirkby added a commit that referenced this pull request Feb 20, 2016
@dkirkby
Merge pull request #29 from desihub/speclite
6d0d478 
Update API
@dkirkby dkirkby merged commit 6d0d478 into master Feb 20, 2016
@dkirkby dkirkby deleted the speclite branch February 20, 2016 01:15
@dkirkby dkirkby mentioned this pull request Feb 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dkirkby