Memory usage improvements #3
Conversation
| m_id(id) | ||
| { | ||
| PWSTR appID; |
There was a problem hiding this comment.
The deleted code here has been moved to DesktopNotificationsManager.cpp
| @@ -2,109 +2,29 @@ | |||
| #include "DesktopNotificationsManager.h" | |||
| #include <iostream> | |||
|
|
|||
| typedef ABI::Windows::Foundation::ITypedEventHandler< | |||
There was a problem hiding this comment.
The deleted code here has been moved to DesktopNotificationsManager.h
| { | ||
| m_appID = std::wstring(appID); | ||
| CoTaskMemFree(appID); | ||
| } |
There was a problem hiding this comment.
This block comes from DesktopNotification.cpp
| return nativeHistory; | ||
| } | ||
| return {}; | ||
| } |
There was a problem hiding this comment.
This was literally moved here from the top of the file, no changes.
| @@ -193,3 +212,86 @@ bool DesktopNotificationsManager::closeNotification(ComPtr<DesktopNotification> | |||
| DN_LOG_ERROR("Notification " << d->getID() << " does not exist"); | |||
| return false; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This whole 🟢 block was brought from DesktopNotification.cpp, and then I added some changes to obtain the notification ID and send it with the callback.
|
|
||
| return E_NOINTERFACE; | ||
| } | ||
|
|
There was a problem hiding this comment.
This block comes from DesktopNotification.h
This comment was marked as spam.
This comment was marked as spam.
| return | ||
| } | ||
|
|
||
| if (event === 'click') { |
There was a problem hiding this comment.
So we can't even be sure that the notification is dismissed if it's clicked? Can it still live on in the notification center?
There was a problem hiding this comment.
We can, yeah! Before this PR, I had some SEGFAULT crashes trying to remove the notification and its callback from memory right after the click event. Then I forgot to do that. I'll tackle that in a different PR along with other minor improvements I want to do.
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
This PR makes a few changes around memory usage. But first, some context:
The changes made in this PR are: