/desktop

New issue

Format the ahead/behind count in a locale-aware manner #1245

Open
joshaber opened this Issue Apr 20, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
polish
Projects
None yet
Milestone
No milestone
2 participants
@joshaber @shiftkey
@joshaber
Contributor

joshaber commented Apr 20, 2017

screen shot 2017-04-20 at 3 03 30 pm

That should be 61,083 in 🇺🇸 and probably something else in other places.

joshaber added the polish label Apr 20, 2017

@shiftkey
Contributor

shiftkey commented Apr 20, 2017

Seems legit:

var number = 10000
number.toLocaleString()

shiftkey self-assigned this Apr 21, 2017

shiftkey referenced this issue Apr 21, 2017

Closed

format these numbers so they have the right separator #1257

shiftkey removed their assignment Apr 27, 2017

@shiftkey
Contributor

shiftkey commented Apr 27, 2017

As discussed in #1257, we should fix this properly. See electron/electron#9247 for the upstream issue and #1257 (comment) for some further context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment