Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the ahead/behind count in a locale-aware manner #1245

Open
joshaber opened this issue Apr 20, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@joshaber
Copy link
Member

commented Apr 20, 2017

screen shot 2017-04-20 at 3 03 30 pm

That should be 61,083 in 馃嚭馃嚫 and probably something else in other places.

@joshaber joshaber added the polish label Apr 20, 2017

@shiftkey

This comment has been minimized.

Copy link
Member

commented Apr 20, 2017

Seems legit:

var number = 10000
number.toLocaleString()
@shiftkey

This comment has been minimized.

Copy link
Member

commented Apr 27, 2017

As discussed in #1257, we should fix this properly. See electron/electron#9247 for the upstream issue and #1257 (comment) for some further context.

@joshaber joshaber added enhancement and removed polish labels Jun 29, 2017

@shiftkey

This comment has been minimized.

Copy link
Member

commented Dec 27, 2017

This idea is interesting for the future, but this is beyond the scope of our current roadmap.

I added the future-proposal label to this issue and closed it so that we won't get overwhelmed with our backlog! We will revisit this in our next planning session.

@iAmWillShepherd

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2018

Reopening this issue now that electron/electron#15035 exists. We should be able to get a proper fix once it lands and we update electron.

@j-f1

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

In #5914, @cheshire137 suggested using a 鈥渒鈥 suffix, which would eliminate the need for locale-specific formatting.

@shiftkey

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Reopening this issue now that electron/electron#15035 exists. We should be able to get a proper fix once it lands and we update electron.

Bumping this to indicate it's currently only available in Electron 5 (currently in beta), and if it's more urgent we'd need to investigate whether we could backport the work to Electron 4.x. My gut feeling is that we can wait until we upgrade to Electron 5, but happy to discuss further...

@j-f1

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

I think it鈥檚 not too urgent because (a) commits don鈥檛 come in fractions and (b) it鈥檚 likely users from countries that use commas as decimal points will have some familiarity with the use of periods, so they鈥檇 get the message. Another alternative is to switch to spaces (鈥61 083鈥) although I鈥檓 not sure how familiar the general population is with that format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.