New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the ahead/behind count in a locale-aware manner #1245

Closed
joshaber opened this Issue Apr 20, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@joshaber
Member

joshaber commented Apr 20, 2017

screen shot 2017-04-20 at 3 03 30 pm

That should be 61,083 in 馃嚭馃嚫 and probably something else in other places.

@joshaber joshaber added the polish label Apr 20, 2017

@shiftkey

This comment has been minimized.

Show comment
Hide comment
@shiftkey

shiftkey Apr 20, 2017

Member

Seems legit:

var number = 10000
number.toLocaleString()
Member

shiftkey commented Apr 20, 2017

Seems legit:

var number = 10000
number.toLocaleString()
@shiftkey

This comment has been minimized.

Show comment
Hide comment
@shiftkey

shiftkey Apr 27, 2017

Member

As discussed in #1257, we should fix this properly. See electron/electron#9247 for the upstream issue and #1257 (comment) for some further context.

Member

shiftkey commented Apr 27, 2017

As discussed in #1257, we should fix this properly. See electron/electron#9247 for the upstream issue and #1257 (comment) for some further context.

@joshaber joshaber added enhancement and removed polish labels Jun 29, 2017

@shiftkey

This comment has been minimized.

Show comment
Hide comment
@shiftkey

shiftkey Dec 27, 2017

Member

This idea is interesting for the future, but this is beyond the scope of our current roadmap.

I added the future-proposal label to this issue and closed it so that we won't get overwhelmed with our backlog! We will revisit this in our next planning session.

Member

shiftkey commented Dec 27, 2017

This idea is interesting for the future, but this is beyond the scope of our current roadmap.

I added the future-proposal label to this issue and closed it so that we won't get overwhelmed with our backlog! We will revisit this in our next planning session.

@shiftkey shiftkey closed this Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment