New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimize to system tray #4098

Closed
shellscriptz opened this Issue Feb 24, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@shellscriptz
Copy link

shellscriptz commented Feb 24, 2018

Description

Want git desktop to have option for tray icon in windows.

Version

GitHub Desktop version: 1.0.13

OS version: windows 10

Steps to Reproduce

  1. github doesn't have a tray icon option

Expected behavior: github has option for a tray icon when minimized

Actual behavior: desktop does not have option for a tray icon when minimized

Reproduces how often: 100%

Logs

Additional Information

@shiftkey

This comment has been minimized.

Copy link
Member

shiftkey commented Feb 26, 2018

@shellscriptz can you tell me a bit more about why you'd like this to be supported? There's no real "background work" that Desktop currently does that might make it preferred to add it to the system tray...

@Kubrix

This comment has been minimized.

Copy link

Kubrix commented Feb 26, 2018

@shiftkey, when GitHub Desktop is in system tray and not in the taskbar, the application is still running and not clogging the taskbar. It might be useful when you have a lot of open programs - in that case any extra taskbar icon (layout) leads to shrinking the current icons.

@shiftkey

This comment has been minimized.

Copy link
Member

shiftkey commented Feb 28, 2018

@Kubrix I think the work required to support this is significantly greater than the benefits, and the majority of (Windows) users won't encounter this. I'll see if @desktop/core has any additional feels on this.

@lee-dohm

This comment has been minimized.

Copy link
Member

lee-dohm commented Feb 28, 2018

Isn't what used to be called the "system tray" now the "notifications area"? From the Windows Design Guidelines:

The notification area was originally intended as a temporary source for notifications and status. Its efficiency and convenience has encouraged developers to give it other purposes, such as launching programs and executing commands. Unfortunately over time, these additions made the notification area too large and noisy, and confused its purpose with the other desktop access points.

Don't abuse the notification area. Use it only as a source for notifications and status, and for features without desktop presence.

Since GitHub Desktop is intended to have a desktop presence, the guidelines would seem to say we shouldn't use the notification area this way.

@shiftkey

This comment has been minimized.

Copy link
Member

shiftkey commented Feb 28, 2018

@lee-dohm excellent points. I'll also make sure to emphasize that last bit:

Use it only as a source for notifications and status, and for features without desktop presence.

The use case for this needs to be more than "declutter the taskbar".

@niik

This comment has been minimized.

Copy link
Contributor

niik commented Feb 28, 2018

Seems like we're all in agreement that this is not something we want to add so I'm going to close this out.

There's also third-party solutions for forcing Windows applications to minimize to the tray (though I haven't tried any of them).

@niik niik closed this Feb 28, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 18, 2018

@desktop desktop unlocked this conversation Sep 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment