Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve "discard all changes" UX #7394

Closed
shiftkey opened this issue Apr 24, 2019 · 9 comments

Comments

7 participants
@shiftkey
Copy link
Member

commented Apr 24, 2019

Please describe the problem you think should be solved

For the longest time we've had the ability to discard all changes by right-clicking the "Changes" header:

This was available on at least the classic Windows app, and it came over in #1647 because we needed somewhere to keep this functionality. Context menus for non-interactive elements like headers aren't very intuitive, but we marched on.

Then we added it to the context menu for a changed file in #4188 (requested in #4314):

This has lead to some confusion in #5342 because it is right next to the "Discard Change" menu item, and if a user doesn't have the "Confirm Discard Changes..." setting enabled they could accidentally move all the files to the trash.

This combination of "header context menu" and "item context menu" makes me think that neither place is the right place for this functionality.

[Optional] Do you have any potential solutions in mind?

in #5342 (comment) we identified a list of changes that will help us to improve this area:

I think we can solve this through implementing these four things, I believe in this order:

  1. Remove Discard All Changes from file context menu
  2. Add Discard All Changes as a top menu item
  3. Remove Discard All Changes from the header context menu
  4. Add a UI menu to the changes top bar (containing Discard All Changes and potential future actions)

For anyone who picks this up:

For 2, I think Discard All Changes should live in Branch > Discard All Changes in a new section between the first and the second section.

For 4, I think we can wait and see how 1-3 feels first before implementing.

@shiftkey shiftkey changed the title "discard all changes" context menu is not discoverable "discard all changes" header context menu is not discoverable Apr 24, 2019

@shiftkey

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

We've made this point before but it got buried in a more complex issue: #5342 (comment)

@shiftkey shiftkey referenced this issue Apr 24, 2019

Merged

lock file state when in rebase conflicts #7377

3 of 3 tasks complete
@tierninho

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

One option is to combine the Discard all Changes and the check all toggle under one cog icon that opens a drop down. This opens the door to add other functionality if needed, like potentially adding the Undo commit button.

56692795-5c000980-66b9-11e9-8020-d9e0cfedae12

@shiftkey shiftkey changed the title "discard all changes" header context menu is not discoverable improve "discard all changes" UX Apr 25, 2019

@shiftkey

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

I've updated the issue body to mention the list of changes we proposed, and I'm going to mark this as help-wanted for someone to pick up.

@shiftkey shiftkey added this to Available in Community via automation Apr 25, 2019

@nerdneha nerdneha added this to PR Needs Triage in PR Priority Apr 26, 2019

@nerdneha nerdneha removed this from PR Needs Triage in PR Priority Apr 26, 2019

@ahuth ahuth referenced this issue Apr 26, 2019

Merged

Improve "Discard all changes" UX #7415

3 of 3 tasks complete
@ahuth

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

Should be resolved in #7415, with the Discard All Changes item moved to the Branches menu.

Community automation moved this from Available to Done May 2, 2019

@karimcambridge

This comment has been minimized.

Copy link

commented Jun 7, 2019

WHY?

There was nothing wrong with the placement of this, both could've existed. The place where it was before actually made alot of sense. But... OK.

@kylefox

This comment has been minimized.

Copy link

commented Jun 9, 2019

I miss the "Discard all changes..." context menu 😕I never would've thought to look under the "Branch" menu item.

@xv

This comment has been minimized.

Copy link

commented Jun 9, 2019

This is such a 💩 change. It doesn't make any sense having this option hidden in the Branch menu. I wasted a good five minutes trying to find the damn option, in which I still didn't and had to come here only to know where it is by reading @kylefox's comment. Bring the old stuff back. Terrible UX choice.

@shiftkey

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

Please follow along with our discussion about this in #7696

@JosephTLyons

This comment has been minimized.

Copy link

commented Jun 10, 2019

Bring back the old functionality or add the gear icon as a button for a drop-down menu. Putting this ONLY in a menu has completely screwed with how quickly and efficiently I can work with Desktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.