Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ReasonML gitignore option #8944

Open
idkjs opened this issue Jan 19, 2020 · 2 comments
Open

Adding ReasonML gitignore option #8944

idkjs opened this issue Jan 19, 2020 · 2 comments
Labels

Comments

@idkjs
Copy link

@idkjs idkjs commented Jan 19, 2020

Describe the feature or problem you’d like to solve

A clear and concise description of what the feature or problem is.

Adding ReasonML .gitignore option to Desktop new repository workflow. Currently there is no reasonml .gitignore option. Here are the options under languages that start with the letter R for the .gitignore menu.

Screenshot 2020-01-19 at 9 00 16 AM

Proposed solution

This is the .gitignore that comes from the ReasonML/Bucklescript react template which might serve as a base.

.DS_Store
.merlin
.bsb.lock
npm-debug.log
/lib/bs/
/node_modules/

How will it benefit Desktop and its users?

This would add a .gitignore option for a recognized github language.

@Rexogamer

This comment has been minimized.

Copy link
Contributor

@Rexogamer Rexogamer commented Jan 19, 2020

This doesn’t seem to exist in the gitignore submodule we use, first open a PR there then we can add it.

@idkjs

This comment has been minimized.

Copy link
Author

@idkjs idkjs commented Jan 19, 2020

Done here: github/gitignore#3291 (comment). Let's see how it goes. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.