Add Reveal in Explorer option to changed file's context menu

[zhuowei]

Fixes #1566.

I tested this on Windows 10; I don't have a Mac, but I think this would still work there since it just uses electron's shell api.

Questions:

• should I refactor the path normalization code into a helper function? I just copied and pasted it from the repo clone code from the same file.

[shiftkey]

A great start @zhuowei! Some feedback to get things moving...

[zhuowei]

Pull request updated:

• per @rlabrecque's suggestion, the open in editor command is now just named "Open"
• moved the path join and normalization code to a helper function

[niik]

In the classic app on Windows we would always open a file with the 'Edit' verb to prevent the user from accidentally executing arbitrary code (like .exe, .js, .com etc). IIRC the default 'Open' action on Windows for .js is the windows script host which will happily run whatever you throw at it.

If we couldn't find a registered Edit verb we still wouldn't launch with the 'Open' verb but rather fall back to opening the file in Explorer.

I think we need to implement similar safeguards here although I'm not quite sure how to specify a verb in this environment.

[zhuowei]

@niik Updated text per comment.

For opening with a separate verb, I can't find any npm modules that can do this, so we may either need to write a module that wraps ShellExecute, or use node-ffi to wrap the function through ffi.

[rlabrecque]

So, my problem with the Edit verb is, how do you even change it? I wouldn't want to open my .js files with notepad which is the default 'Edit' action. In this case I'd expect that I would be opening the file in VSCode which is my default after going through, open with -> set as default.

Opening explorer if there was no default association feels weird too, why not just let the OS deal with this?

[niik]

For opening with a separate verb, I can't find any npm modules that can do this, so we may either need to write a module that wraps ShellExecute, or use node-ffi to wrap the function through ffi.

Yeah, I think we should land this PR with just the 'Reveal in Finder/Show in Explorer' menu item and push the open option further down the line. It's tricky to get right and on macOS it seems like although there's an equivalent of the edit verb it can't be trusted to not execute code. I think as we start to get into 'Open in Atom/Open in [insert favorite IDE here]' the need for a generic open item will diminish somewhat.

[shiftkey]

@zhuowei this looks like it's close, however there's a merge conflict that needs to be 🔥'd first.

[niik]

@shiftkey also #1677 (comment)

[shiftkey]

@niik 👍 gonna drop myself off this review, but feel free to pull me in if you want an extra set of 👀

[zhuowei]

@niik Open button removed; only the Reveal in Finder/Open in Explorer menu item is left. Also, conflict resolved.

[niik]

Looking good @zhuowei, I had a few questions 👇

[zhuowei]

Addressed @niik's comments.

[zhuowei]

Rebased to fix build.

[niik]

Nicely done @zhuowei, thank you!