Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add small space between commit summary and description #3922
Hi @willnode, thanks for the pull request! Can you explain the reason for bumping down the commit description?
One other thing to note, you'll also need to increase the row height of the list item here (probably by the amount you changed):
This is because the height itself is fixed and the vertical padding becomes uneven as a result (the bottom padding as less space):
@donokuda The original design is already looking good. But whenever I see a commit message have difference of only 1 pixel below the profile picture (e.g. emoji or
I wasn't knew where to change the row height so thanks for pointing that. I can make it bigger by 2px, but I'm waiting for feedback.
Updated comparison: (original; PR at this state; after resized by +2px)
@willnode Thanks for the clarification!
I totally agree and this looks like a good improvement. When you push the changes I suggested above, feel free to request my review and I can jump in on it. (Bonus points for attaching a screenshot like how you've done earlier