Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group and filter repositories by owner #6923

Merged
merged 7 commits into from Feb 26, 2019

Conversation

Projects
None yet
4 participants
@outofambit
Copy link
Member

commented Feb 22, 2019

Overview

partly addresses #6460
reboot of #6896

filter by owner with grouping by owner

Description

  • group and display github.com repositories by organization
  • filter text field searches the owner field
  • feature flagged for beta currently

Release notes

Notes: [Improved] Group and filter GitHub repositories by owner name

@outofambit outofambit marked this pull request as ready for review Feb 22, 2019

@outofambit outofambit added this to the 1.6.3 milestone Feb 22, 2019

@outofambit

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

marking this time sensitive since i'd like this to ship to beta this week

@outofambit outofambit requested a review from desktop/engineering Feb 25, 2019

@outofambit

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

marking this time sensitive since i'd like this to ship to beta this week

i would still like to ship this to beta this week, but we don't need to and have other pending work to support currently :)

@shiftkey shiftkey self-assigned this Feb 25, 2019

@tierninho

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Tested the functionality and LGTM. Could not test Enterprise repos as it does not work in dev mode.

@shiftkey
Copy link
Member

left a comment

Code looks good, just going to let this sit for the day to give others a chance to provide feedback.

@shiftkey shiftkey merged commit 3094b0f into development Feb 26, 2019

4 checks passed

Continuous Integration #20190225.29 succeeded
Details
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@shiftkey shiftkey deleted the feature/group-by-owner branch Feb 26, 2019

@say25

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

Looked this over from a UI perspective, not sure if it is worth re-adding GitHub.com and Enterprise groupings with Owner grouping below that?

@shiftkey

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

not sure if it is worth re-adding GitHub.com and Enterprise groupings with Owner grouping below that?

Enterprise grouping should not be affected by this change. I'm indifferent to whether there's value in displaying GitHub.com before the org groups (I don't think we can nest three levels deep in here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.