Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable create PR suggestion for production #7505

Merged

Conversation

Projects
4 participants
@niik
Copy link
Contributor

commented May 10, 2019

Overview

This reverts #6641, enabling the create pull request suggested next step for prod. It was initially slated to ship alongside the other suggested actions but during testing we realized that the underlying data source for open pull requests was not reliable (see #6982). Once #7501 has landed we should be able to open this up to production.

Closes #6673

Description

image

Release notes

Notes: [New] Suggested next step for creating a pull request after publishing a branch

@niik niik added this to Review in progress in PR Priority May 10, 2019

@niik niik moved this from Review in progress to 🛑 Blocked in PR Priority May 10, 2019

@outofambit outofambit added this to the 1.7.0 milestone May 14, 2019

@billygriffin

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

Updated this PR description to strikethrough the top portion now that #7501 is landed!

@shiftkey shiftkey moved this from 🛑 Blocked to Needs to be Prioritized in PR Priority May 16, 2019

@shiftkey shiftkey moved this from Needs to be Prioritized to Review in progress in PR Priority May 16, 2019

@shiftkey shiftkey moved this from Review in progress to ⭐️ PR Reviewable Priority ⭐️ in PR Priority May 16, 2019

PR Priority automation moved this from ⭐️ PR Reviewable Priority ⭐️ to Awaiting Merge May 20, 2019

@outofambit outofambit self-assigned this May 20, 2019

@nerdneha nerdneha added this to Needs Triage in 2.0.0 Release May 20, 2019

@nerdneha nerdneha moved this from Needs Triage to Review in Progress in 2.0.0 Release May 21, 2019

@outofambit outofambit merged commit 655dc14 into development May 23, 2019

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Continuous Integration #20190522.18 succeeded
Details
ci/circleci: build Your tests passed on CircleCI!
Details
codecov/project/lib-app 34.1% remains the same compared to 1fcfe4f
Details
codecov/project/lib-git 73.9% remains the same compared to 1fcfe4f
Details
codecov/project/models 64.1% remains the same compared to 1fcfe4f
Details
codecov/project/ui-components 17.6% (-0.1%) compared to 1fcfe4f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

PR Priority automation moved this from Awaiting Merge to Done May 23, 2019

2.0.0 Release automation moved this from Review in Progress to Done May 23, 2019

@outofambit outofambit deleted the you-get-a-pr-suggestion-and-you-get-a-pr-suggestion branch May 23, 2019

@niik niik referenced this pull request Jun 3, 2019

Merged

release notes for the next big release #7656

1 of 1 task complete

@pccasto pccasto referenced this pull request Jun 5, 2019

Closed

Merge to master #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.