New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lock reason with "resolved" #3

Merged
merged 1 commit into from May 1, 2018

Conversation

2 participants
@hzoo
Copy link
Contributor

hzoo commented Apr 30, 2018

Ref babel/babel#7839 (comment)

For the preview, I looked at https://github.com/octokit/rest.js#api-previews and you can already just pass a header (thanks @gr2m)

image

When locking an issue via the issues API, you can now provide an optional reason that will be visible to anyone who views the issue. Valid lock reasons are "off-topic", "too heated", "resolved", and "spam". Providing a lock reason can help make it clearer to contributors why an issue was locked, and what kinds of behavior may result in issues being locked in the future.

resolved seems to make the most since here so I just hardcoded it. Although maybe we can suggest a new one for this use-case. Feel free to modify this PR if needed

@dessant dessant merged commit a5dbbcd into dessant:master May 1, 2018

@dessant

This comment has been minimized.

Copy link
Owner

dessant commented May 1, 2018

@hzoo, looks great, the change has been deployed, thanks a lot!

@hzoo

This comment has been minimized.

Copy link
Contributor

hzoo commented May 1, 2018

Awesome thanks! will try to merge babel/babel#7839 next!

@hzoo

This comment has been minimized.

Copy link
Contributor

hzoo commented May 1, 2018

Also this was an obvious answer too https://twitter.com/pshrmn/status/991093233475293184

maybe we should add an optional label in place of a comment (like outdated)

@hzoo

This comment has been minimized.

Copy link
Contributor

hzoo commented May 1, 2018

Ok made #4 if that is useful

@dessant dessant referenced this pull request Jun 22, 2018

Closed

Bot locking "as resolved" #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment