This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
For WebSocket upgrade requests,
gorilla/websocketcallsCheckOriginto determine if the upgrade should be performed. The function should "carefully validate the request origin to prevent cross-site request forgery".The current implementation immediately returns
true, essentially performing no check. If undefined, a "safe default" is used, which only upgrades the request if the host component of theOriginheader matches theHostheader.This PR removes the current implementation so the default is used.