From a8580cbe886eb89fb09d89b109c7053c63bf26f3 Mon Sep 17 00:00:00 2001 From: Matthew Haughton <3flex@users.noreply.github.com> Date: Sun, 26 Nov 2023 16:37:01 +1100 Subject: [PATCH] Only call getNameAsSafeName on instances of KtNamedDeclaration --- .../io/gitlab/arturbosch/detekt/rules/style/UnnecessaryLet.kt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryLet.kt b/detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryLet.kt index d5a406c99fd3..9b746b06b28e 100644 --- a/detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryLet.kt +++ b/detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/UnnecessaryLet.kt @@ -14,6 +14,7 @@ import org.jetbrains.kotlin.descriptors.impl.ValueParameterDescriptorImpl.WithDe import org.jetbrains.kotlin.name.FqName import org.jetbrains.kotlin.psi.KtCallExpression import org.jetbrains.kotlin.psi.KtLambdaExpression +import org.jetbrains.kotlin.psi.KtNamedDeclaration import org.jetbrains.kotlin.psi.KtQualifiedExpression import org.jetbrains.kotlin.psi.KtSafeQualifiedExpression import org.jetbrains.kotlin.psi.KtSimpleNameExpression @@ -104,6 +105,7 @@ private fun canBeReplacedWithCall(lambdaExpr: KtLambdaExpression?): Boolean { } else { lambdaParameter.destructuringDeclaration?.entries.orEmpty() .plus(lambdaParameter) + .filterIsInstance() .map { it.nameAsSafeName.asString() } } return lambdaParameterNames.any { receiver.textMatches(it) }