From bef771ce9e148997fc45c61f8de1d1495bd63c5f Mon Sep 17 00:00:00 2001 From: Matthew Haughton <3flex@users.noreply.github.com> Date: Tue, 12 Mar 2024 18:43:27 +1100 Subject: [PATCH] Allow setting default autocorrect mode with Gradle property This makes it possible to enable autocorrect when running tasks that depend on detekt tasks e.g. ./gradlew check -Pdetekt.default.autocorrect=true Without this, the only way to enable autocorrect on CLI is by declaring every detekt task on the CLI and passing --auto-correct to every one. --- .../main/kotlin/dev/detekt/gradle/plugin/DetektBasePlugin.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/detekt-gradle-plugin/src/main/kotlin/dev/detekt/gradle/plugin/DetektBasePlugin.kt b/detekt-gradle-plugin/src/main/kotlin/dev/detekt/gradle/plugin/DetektBasePlugin.kt index d6db1571e07d..9c2cbac60ff3 100644 --- a/detekt-gradle-plugin/src/main/kotlin/dev/detekt/gradle/plugin/DetektBasePlugin.kt +++ b/detekt-gradle-plugin/src/main/kotlin/dev/detekt/gradle/plugin/DetektBasePlugin.kt @@ -39,7 +39,7 @@ class DetektBasePlugin : Plugin { allRules.convention(DEFAULT_ALL_RULES_VALUE) buildUponDefaultConfig.convention(DEFAULT_BUILD_UPON_DEFAULT_CONFIG_VALUE) disableDefaultRuleSets.convention(DEFAULT_DISABLE_RULESETS_VALUE) - autoCorrect.convention(DEFAULT_AUTO_CORRECT_VALUE) + autoCorrect.convention(project.providers.gradleProperty(ENABLE_AUTOCORRECT).map { it.toBoolean() }) reportsDir.convention( project.extensions.getByType(ReportingExtension::class.java).baseDirectory.dir("detekt") ) @@ -107,7 +107,6 @@ class DetektBasePlugin : Plugin { private const val DEFAULT_IGNORE_FAILURES = false private val DEFAULT_FAIL_ON_SEVERITY = FailOnSeverity.Error private const val DEFAULT_PARALLEL_VALUE = false - private const val DEFAULT_AUTO_CORRECT_VALUE = false private const val DEFAULT_DISABLE_RULESETS_VALUE = false private const val DEFAULT_ALL_RULES_VALUE = false private const val DEFAULT_BUILD_UPON_DEFAULT_CONFIG_VALUE = false @@ -118,3 +117,4 @@ class DetektBasePlugin : Plugin { } internal const val CONFIGURATION_DETEKT_PLUGINS = "detektPlugins" +internal const val ENABLE_AUTOCORRECT = "detekt.default.autocorrect"