Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThrowingExceptionInMain rule should consider main() function with no parameters #2248

Closed
schalkms opened this issue Jan 11, 2020 · 0 comments · Fixed by #2240
Closed

ThrowingExceptionInMain rule should consider main() function with no parameters #2248

schalkms opened this issue Jan 11, 2020 · 0 comments · Fixed by #2240
Labels
bug rules
Milestone
1.4.0

Comments

@schalkms
Copy link
Member

As of Kotlin 1.3, the explicit Array can be omitted but will still be available in the byte code.
Reference

Expected Behavior

The rule should also flag parameterless main() functions that throw an exception.

fun main() { throw IllegalArgumentException() }

Observed Behavior

The rule ignores parameterless main() functions.

Your Environment

  • Version of detekt used: 1.3.1
  • Operating System and version: macOS 10.14.6
@schalkms schalkms mentioned this issue Jan 12, 2020
Merged
3flex pushed a commit that referenced this issue Jan 12, 2020
@schalkms @3flex
ThrowingExceptionInMain: fix #2248 and add tests (#2240)
5c0bdda 
* Add tests for ThrowingExceptionInMain rule

* Update test case to throw exception inside main()

* Update test description (grammar)

* Consider parameterless main() in ThrowingExceptionInMain rule

Fixes #2248

* Add tests for parameterless main() and for some negative cases

* Refactor duplicated condition in isMainFunction()

This commit also fixes a codefactor warning.

* Add test for top level main with expression body
@arturbosch arturbosch added this to the 1.4.0 milestone Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug rules
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

ThrowingExceptionInMain: fix #2248 and add tests
2 participants
@arturbosch @schalkms