Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failed with... is printed twice in the cli #2264

Closed
BraisGabin opened this issue Jan 17, 2020 · 2 comments
Closed

Build failed with... is printed twice in the cli #2264

BraisGabin opened this issue Jan 17, 2020 · 2 comments
Labels
cli improvement
Milestone
1.5.0

Comments

@BraisGabin
Copy link
Member

Expected Behavior

If I run the cli and I have issues at the end of the output I get the numer of issues onces

Observed Behavior

I'm getting this output twice:

Build failed with 3178 weighted issues (threshold defined was 10).
io.gitlab.arturbosch.detekt.cli.BuildFailure: Build failed with 3178 weighted issues (threshold defined was 10).

Steps to Reproduce

Run the cli on a project that have issues

Context

I found this issue testing #2258 and then I saw that it was in master too.

Your Environment

  • Version of detekt used: master (1.4.0)
@BraisGabin
Copy link
Member Author

I checked the code and this is because the BuildFailureReport show this message once and then the Runner throws an exception with exactly the same message.

arturbosch added a commit that referenced this issue Jan 19, 2020
@arturbosch
Remove redundant build failure message - #2264
af59738
@arturbosch arturbosch added this to the 1.5.0 milestone Jan 19, 2020
arturbosch added a commit that referenced this issue Jan 19, 2020
@arturbosch
Remove redundant build failure message - #2264
b6ab2de
arturbosch added a commit that referenced this issue Jan 19, 2020
@arturbosch
Remove redundant build failure message - #2264
6bd5029
arturbosch added a commit that referenced this issue Jan 19, 2020
@arturbosch
Remove redundant build failure message - #2264 (#2266)
859676e
@BraisGabin
Copy link
Member Author

We can close this now, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli improvement
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@BraisGabin @arturbosch