Align cli flags and defaults with other analysis tools

[arturbosch]

Expected Behavior

--build-upon-default-config should be true by default.
new flag --all-rules which activates all rules
remove --fail-fast
introduce new flag --max-issues to quickly manipulate the number of allowed issues without having a config file.

Current Behavior

--fail-fast does three things: --build-upon-default-config + maxIssues=0 + activates all rules

Context

Align behavior wiht tools like PMD and ESLint

[BraisGabin]

Are we sure that --fail-fast always sets the maxIssues to 0? The code doesn't do that:

detekt/detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/internal/FailFastConfig.kt

Line 15 in c1ebc03

"maxIssues" -> originalConfig.valueOrDefault(key, 0) as T

and even the tests doesn't assert that:

detekt/detekt-core/src/test/kotlin/io/gitlab/arturbosch/detekt/core/WorkaroundConfigurationKtSpec.kt

Line 68 in c1ebc03

assertThat(config.subConfig("build").valueOrDefault("maxIssues", -1)).isEqualTo(1)

I vote to remove --fail-fast. It's buggy and no one complained about it. And it only active all rules in really special situations because nearly always we end up using the default configuration as the base configuration and because of this line:

detekt/detekt-api/src/main/kotlin/io/gitlab/arturbosch/detekt/api/internal/FailFastConfig.kt

Line 14 in c1ebc03

"active" -> originalConfig.valueOrDefault(key, true) as T

We just run the rules that are active by default.

--all-rules and --max-issues are the way to go.

[arturbosch]

Your right, it set the default maxIssues = 0 when the old threshold was 10, configs can overwrite it.
Now it's just --build-upon-default-config + activates all rules.

@BraisGabin have you started with this issue? If not, I would like to look at this next.
It can be implemented in a backwards compatible manner.

[BraisGabin]

You can do it. All my work is the wip pr that I want to close (#2999). I'll try to focus on the dsl.

[arturbosch]

You can do it. All my work is the wip pr that I want to close. I'll try to focus on the dsl.

Ah, rediscovered your PR. A good starting point.