Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FailFastConfig.valueOrNull should return specified value for active and maxIssues #2316

Closed
robstoll opened this issue Feb 4, 2020 · 0 comments · Fixed by #2319
Closed

FailFastConfig.valueOrNull should return specified value for active and maxIssues #2316

robstoll opened this issue Feb 4, 2020 · 0 comments · Fixed by #2319
Labels
api improvement
Milestone
1.6.0

Comments

@robstoll
Copy link
Contributor

robstoll commented Feb 4, 2020

Expected Behavior

valueOrNull delegates to originalConfig if value was defined

Observed Behavior

valueOrNull does not delegate to originalConfig for active and for maxIssues

Steps to Reproduce

ConfigurationsSpec -> should override active when specified -> switch to valueOrNull

Context

I had a look at the assertions used in detekt to see if Atrium would be a good fit. I'll create a WIP PR later on so that you can decide on your own.

Your Environment

  • Version of detekt used: master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api improvement
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

use same behaviour for valueOrNull as for valueOrDefault robstoll/detekt
3 participants
@robstoll @arturbosch @schalkms