detekt does not always inject the required EDITOR_CONFIG_USER_DATA_KEY for ktlint

[sschuberth]

This is a follow-up issue for #1803 as I believe @schalkms' statement of "Since detekt provides a wrapper over ktlint, this is not directly a problem of detekt" is not correct, and the issue seems to be in detekt, not in ktlint, as detekt does not properly inject EDITOR_CONFIG_USER_DATA_KEY before calling ktlint.

Expected Behavior

Enabling ktlint's FinalNewline rule should not crash detekt.

Observed Behavior

Enabling ktlint's FinalNewline rule does crash detekt.

Steps to Reproduce

Use

FinalNewline:
    active: true

on a file with missing final new line.

Context

ktlint expects the EDITOR_CONFIG_USER_DATA_KEY to be present, and detekt actually has code to add it, but that code does not seem to be called as FinalNewline does not override editorConfigUpdater to return something different than null.

Your Environment

• Version of detekt used: 1.5.1
• Version of Gradle used (if applicable): 6.1.1
• Operating System and version: Windows 10
• Link to your project (if it's a public repository): https://github.com/heremaps/oss-review-toolkit

[schalkms]

Thanks for bringing up this issue again and describing the bug in detail with sample code, so that we can reproduce it!
Yes, my statement in the linked issue is wrong. Based on the issue report it wasn't possible to reproduce it.