False positive: UnconditionalJumpStatementInLoop with elvis operator ?:

[BraisGabin]

Expected Behavior

The elvis operator is a conditional so code like this should be accepted:

for (resource in Detektor::class.java.classLoader.getResources("META-INF/MANIFEST.MF")) {
    return runCatching { readVersion(resource) }.getOrNull() ?: continue
}

Observed Behavior

It fails

Context

We found this false positive at #2387

Your Environment

• Version of detekt used: 1.6.0

[schalkms]

Fixed by a9bb93e

[michalsikora-silvair]

I'm getting this in 1.18.1.

fun function(items: List<Int?>): String? {
    for (item in items) {
        val intItem = item ?: continue
        return intItem.toString()
    }
    return null
}

Unless it is different due to return in different statement. I can't inline it in the real code as there is more data processing in between.

EDIT:

Yup, seems that return in the same line fixes it. Should I open different issue?

[BraisGabin]

Yes, please, open a new issue.

[michalsikora-silvair]

Will do. :)

[MiSikora]

Filed in #4134.