Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file does not end with .yml! #2417

Closed
Fleshgrinder opened this issue Mar 7, 2020 · 1 comment · Fixed by #2419
Closed

file does not end with .yml! #2417

Fleshgrinder opened this issue Mar 7, 2020 · 1 comment · Fixed by #2419
Labels
api improvement
Milestone
1.7.0

Comments

@Fleshgrinder
Copy link
Contributor

Trying to load a .yaml file leads to an exception with the message from the issue title. The official YAML FAQ recommends .yaml over .yml and I also believe that it is not up to detekt to prescribe what the file extension has to be. This choice should be up to the project. 😊
@schalkms
Copy link
Member

schalkms commented Mar 8, 2020

I agree with that. I never understood why detekt handles it this way.

@Fleshgrinder Fleshgrinder mentioned this issue Mar 8, 2020
Merged
@arturbosch arturbosch added this to the 1.7.0 milestone Mar 8, 2020
arturbosch pushed a commit that referenced this issue Mar 8, 2020
@Fleshgrinder
Remove YAML Extension Requirement (#2419)
dd45144 
* Remove YAML Extension Requirement

Closes #2417

* Add sanity checks

* Remove unused import

* Update Documentation
@schalkms schalkms mentioned this issue Mar 9, 2020
Merged
schalkms added a commit that referenced this issue Mar 11, 2020
@schalkms
Add tests for YamlConfig (#2426)
41775a4 
* Add tests for YamlConfig

subsequent task of #2417

* Fix non-existing path in test

* Merge test cases in YamlConfigSpec and ConfigSpec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api improvement
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Remove YAML Extension Requirement
3 participants
@Fleshgrinder @arturbosch @schalkms