-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComplexInterface - should it also count private methods? #2446
Comments
I don't think so. Having too many private methods could be easily spotted by this other rule: https://arturbosch.github.io/detekt/complexity.html#toomanyfunctions I like to think at |
Exactly my thoughts, thanks for opinion. |
Thanks for raising this interesting discussion thread. |
I think that there was a confusion here. If we all agree (I agree too) we should fix it. Becase, right now, |
Agree, this should be fixed. Here a potential fix #2478 |
ComplexInterface
is triggered even if the number of overrideable functions / properties is less than treshold, but there are private methods within the interface (used by default implementation of the functions), which trigger the rule.Should it be the case? Instinctively, I would not think they would be counted, but maybe I am wrong..
The text was updated successfully, but these errors were encountered: