Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support yaml lists in the configuration values #2498

Closed
18 tasks done
BraisGabin opened this issue Mar 22, 2020 · 2 comments
Closed
18 tasks done

Support yaml lists in the configuration values #2498

BraisGabin opened this issue Mar 22, 2020 · 2 comments

Comments

@BraisGabin
Copy link
Member

BraisGabin commented Mar 22, 2020

This issue is a continuation of #2463. There we talked about ForbiddenImports but we should generalice that solution to the rest of lists that we have in our yaml config file. (This case was implemented already #2474).

The reason for doing this is:

  • It's easier to mantain the configuration using lists than strings
  • We don't need to handle strange cases splitting strings (empty strings and similar)

The idea is to allow the use of yaml list where we are now using a string with ,. And if all goes well remove we can remove this old way in 2.0.

This is the list of configurations that, in 1.7.0, are lists splited by ,:

  • *>excludes
  • ComplexMethod>nestingFunctions
  • ExceptionRaisedInUnexpectedLocation>methodNames
  • ForbiddenClassName>forbiddenName
  • ForbiddenComment>values
  • ForbiddenImport>imports
  • ForbiddenMethodCall>methods
  • ForbiddenPublicDataClass>ignorePackages
  • FunctionOnlyReturningConstant>excludeAnnotatedFunctions
  • LabeledExpression>ignoredLabels
  • LateinitUsage>excludeAnnotatedProperties
  • LongParameterList>ignoreAnnotated
  • MagicNumber>ignoreNumbers
  • SwallowedException>ignoredExceptionTypes
  • ThrowingExceptionsWithoutMessageOrCause>exceptions
  • UnnecessaryAbstractClass>excludeAnnotatedClasses
  • UseDataClass>excludeAnnotatedClasses
  • WildcardImport>excludeImports
@BraisGabin
Copy link
Member Author

All the PRs are done now :)

@arturbosch
Copy link
Member

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants