Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.1 does not depend on Kotlin 1.3.71 #2527

Closed
reubenfirmin opened this issue Mar 27, 2020 · 8 comments
Closed

1.7.1 does not depend on Kotlin 1.3.71 #2527

reubenfirmin opened this issue Mar 27, 2020 · 8 comments

Comments

@reubenfirmin
Copy link

Looks like #2507 intended to set dependency to 1.3.71 but that doesn't work.

Also, please exclude dependencies of org.jetbrains.kotlinx:kotlinx-html-jvm, since it has older stdlib dependencies.

detekt - The detekt dependencies to be used for this project.
\--- io.gitlab.arturbosch.detekt:detekt-cli:1.7.1
     +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.70
     |    +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.3.70
     |    \--- org.jetbrains:annotations:13.0
     +--- io.gitlab.arturbosch.detekt:detekt-core:1.7.1
     |    +--- io.gitlab.arturbosch.detekt:detekt-api:1.7.1
     |    |    +--- org.jetbrains.kotlin:kotlin-compiler-embeddable:1.3.70
     |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.70 (*)
     |    |    |    +--- org.jetbrains.kotlin:kotlin-script-runtime:1.3.70
     |    |    |    +--- org.jetbrains.kotlin:kotlin-reflect:1.3.70
     |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.70 (*)
     |    |    |    +--- org.jetbrains.kotlin:kotlin-daemon-embeddable:1.3.70
     |    |    |    \--- org.jetbrains.intellij.deps:trove4j:1.0.20181211
     |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.70 (*)
     |    |    \--- org.yaml:snakeyaml:1.26
     |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.70 (*)
     +--- com.beust:jcommander:1.78
     +--- org.jetbrains.kotlinx:kotlinx-html-jvm:0.7.1
     |    +--- org.jetbrains.kotlinx:kotlinx-html-common:0.7.1
     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.3.61
     |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.61 -> 1.3.70 (*)
     |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.3.61
     |    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.61 -> 1.3.70 (*)
     |    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.3.61 -> 1.3.70
     \--- io.gitlab.arturbosch.detekt:detekt-rules:1.7.1
          +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.70 (*)
          \--- io.gitlab.arturbosch.detekt:detekt-api:1.7.1 (*)
@BraisGabin
Copy link
Member

That's not what I get from master

detekt - The detekt dependencies to be used for this project.
+--- project :detekt-cli (*)
+--- org.jetbrains.kotlin:kotlin-stdlib:1.3.71
|    +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.3.71
|    \--- org.jetbrains:annotations:13.0
+--- project :detekt-core
|    +--- project :detekt-api
|    |    +--- org.jetbrains.kotlin:kotlin-compiler-embeddable:1.3.71
|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.71 (*)
|    |    |    +--- org.jetbrains.kotlin:kotlin-script-runtime:1.3.71
|    |    |    +--- org.jetbrains.kotlin:kotlin-reflect:1.3.71
|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.71 (*)
|    |    |    +--- org.jetbrains.kotlin:kotlin-daemon-embeddable:1.3.71
|    |    |    \--- org.jetbrains.intellij.deps:trove4j:1.0.20181211
|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.71 (*)
|    |    \--- org.yaml:snakeyaml:1.26
|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.71 (*)
+--- com.beust:jcommander:1.78
+--- org.jetbrains.kotlinx:kotlinx-html-jvm:0.7.1
|    +--- org.jetbrains.kotlinx:kotlinx-html-common:0.7.1
|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.3.61
|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.61 -> 1.3.71 (*)
|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.3.61
|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.3.61 -> 1.3.71 (*)
|    \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.3.61 -> 1.3.71
\--- project :detekt-rules
     +--- org.jetbrains.kotlin:kotlin-stdlib:1.3.71 (*)
     \--- project :detekt-api (*)

@BraisGabin
Copy link
Member

BraisGabin commented Mar 27, 2020

Anyway... it's strange that the kotlin's gradle bom is not updating kotlin-stdlib-jdk7 and kotlin-stdlib-jdk8... It should not be a problem, but it's strange.

@imanushin
Copy link
Contributor

Probably this is because both kotlin-stdlib-jdk7 and kotlin-stdlib-jdk8 were received from kotlinx-html-jvm. And detekt references only kotlin-stdlib, e.g. another library (which is also mandatory), however without any suffixes.

@schalkms
Copy link
Member

Is this related to #2501 ?

@BraisGabin
Copy link
Member

I really don't think so. I think that it's not related. But we could check.

@arturbosch
Copy link
Member

arturbosch commented Mar 28, 2020

Thanks for insights, I've changed the dependencies a bit to get:
Screenshot from 2020-03-28 08-54-03

arturbosch added a commit that referenced this issue Mar 28, 2020
* Use kotlin-stdlib-jdk8 to reduce dependency conflicts - #2527

* Exclude transitive kotlin dependencies from html jvm lib - #2527
@sschuberth
Copy link
Contributor

sschuberth commented Mar 28, 2020

Is this related to #2501 ?

I really don't think so. I think that it's not related. But we could check.

I tried locally, and this seems to indeed also resolve #2501, but I'll wait for CI to verify.

Edit: Yes, #2501 is fixed in detekt 1.7.2 🎉

@arturbosch
Copy link
Member

arturbosch commented Mar 28, 2020

Thanks for the verification @sschuberth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants