Skip to content

Configure default excludes for InvalidPackageDeclaration #2539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arturbosch opened this issue Mar 28, 2020 · 1 comment · Fixed by #3305
Closed

Configure default excludes for InvalidPackageDeclaration #2539

arturbosch opened this issue Mar 28, 2020 · 1 comment · Fixed by #3305
Labels
improvement rules
Milestone
1.16.0

Comments

@arturbosch
Copy link
Member

arturbosch commented Mar 28, 2020 •
edited
Loading

Expected Behavior

We should exclude *.gradle.kts files by default. Maybe even *.kts files?

Current Behavior

InvalidPackageDeclaration flags gradle.kts for not having a package declaration.

Context

A failfast configured codeac instance with rule defaults.
@BraisGabin
Copy link
Member

Do you mean *.gradle.kts? Anyway I vote for *.kts.

schalkms added a commit that referenced this issue Dec 19, 2020
@schalkms
Configure default excludes for InvalidPackageDeclaration
69d4787 
Closes #2539
@schalkms schalkms mentioned this issue Dec 19, 2020
Merged
schalkms added a commit that referenced this issue Dec 21, 2020
@schalkms
Configure default excludes for InvalidPackageDeclaration (#3305)
75ce32e 
* Configure default excludes for InvalidPackageDeclaration

Closes #2539

* Adapt to generator to output .kts

* Refactor the generator to support different excludes
* Each rule and rule set can only have one exclude pattern
@arturbosch arturbosch added this to the 1.16.0 milestone Dec 21, 2020
arturbosch pushed a commit that referenced this issue Jan 16, 2021
@schalkms @arturbosch
Configure default excludes for InvalidPackageDeclaration (#3305)
ccf731c 
* Configure default excludes for InvalidPackageDeclaration

Closes #2539

* Adapt to generator to output .kts

* Refactor the generator to support different excludes
* Each rule and rule set can only have one exclude pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement rules
Projects
None yet
Milestone
1.16.0
Development

Successfully merging a pull request may close this issue.

Configure default excludes for InvalidPackageDeclaration detekt/detekt
3 participants
@BraisGabin @arturbosch @schalkms