Treat config property deprecations as errors

[arturbosch]

Expected Behavior

Implement an option to fail the build if any deprecated properties are used:

config:
  validation: true
  warningsAsErrors: true
  excludes: ...

Current Behavior

New behavior treats them as warnings which do not fail the build.

Context

Old behavior treated them as errors which was considered a bug due to updating the detekt version should not unexpectedly break the build - #2523

[NullByte08]

Current Behaviour

New behavior treats them as warnings which do not fail the build.

and issue title says

Treat config property deprecations as errors

I am confused whether to treat them as errors in my code or not.

I encountered an error
Task :app:detekt Property 'complexity>LongParameterList>threshold' is deprecated. Use 'functionThreshold' and 'constructorThreshold' instead. naming - 5min debt PackageNaming - [HotspotNotificationManager.kt] at F:\Kiwix\kiwix-android\app\src\main\java\org\kiwix\kiwixmobile\webserver\wifi_hotspot\HotspotNotificationManager.kt:18:1 Overall debt: 5min

Is there an error in my code, or should I just replace the deprecated property threshold(if yes then with functionThreshold or contructorThreshold?) ?

[arturbosch]

Current Behaviour

New behavior treats them as warnings which do not fail the build.

and issue title says

Treat config property deprecations as errors

I am confused whether to treat them as errors in my code or not.

Hi @NullByte08 ,
it depends. The default behavior prints a warning. If you want to migrate the properties right away on detekt upgrade, you might want to add warningsAsErrors: true. It's like with compiler warnings. If you want a zero warnings polity, feel free to turn this option on.

I encountered an error
Task :app:detekt Property 'complexity>LongParameterList>threshold' is deprecated. Use 'functionThreshold' and 'constructorThreshold' instead. naming - 5min debt PackageNaming - [HotspotNotificationManager.kt] at F:\Kiwix\kiwix-android\app\src\main\java\org\kiwix\kiwixmobile\webserver\wifi_hotspot\HotspotNotificationManager.kt:18:1 Overall debt: 5min

Is there an error in my code, or should I just replace the deprecated property threshold(if yes then with functionThreshold or contructorThreshold?) ?

There is no error. We just deprecated threshold in favor of two new properties, one just for functions, one just for constructors.
Add both new properties:

detekt/detekt-core/src/main/resources/default-detekt-config.yml

Lines 92 to 98 in fb1144e

	LongParameterList:
	active: true
	functionThreshold: 6
	constructorThreshold: 7
	ignoreDefaultParameters: false
	ignoreDataClasses: true
	ignoreAnnotated: []

[NullByte08]

@arturbosch Ok I am removing threshold and adding those properties. Thanks.