Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov test coverage report doesn't work correctly #2558

Closed
schalkms opened this issue Mar 30, 2020 · 5 comments
Closed

codecov test coverage report doesn't work correctly #2558

schalkms opened this issue Mar 30, 2020 · 5 comments
Labels
Milestone

Comments

@schalkms
Copy link
Member

schalkms commented Mar 30, 2020

Expected Behavior

The codecov report should report the test coverage for all packages inside the detekt repository.

Observed Behavior

The codecov report reports 0 % coverage for 3 packages (formatting...)
Furthermore, it doesn't yield the correct coverage for other packages. It's too low.

Steps to Reproduce

Take a look at the dashboard:
https://codecov.io/gh/arturbosch/detekt

Context

The coverage report gives a good indication on how well a feature is tested.

The problem occured after merging 8a48551.

@schalkms schalkms added the ci label Mar 30, 2020
@arturbosch
Copy link
Member

arturbosch commented Apr 6, 2020

It seems that we run the codecoverage action for each OS and JVM. Maybe the Gradle caching leads to incomplete results.
Maybe it's worth to try to add a custom isolated Github action just for the coverage: detekt clean test jacocoTestReport -Dorg.gradle.caching=false.

@cortinico
Copy link
Member

I was actually thinking about this issue last week. We should probably publish the codecov report only from one instance of the CI matrix (say Ubuntu - JDK 8).

The current setup could create concurrency problems where the first worker that succeeds will actually be the one where you read the coverage report from.

@arturbosch
Copy link
Member

I've run sonar-kotlin over detekt and got a test coverage of 76.6%.
So this is definitely our CI not the gradle build file refactoring ^^

@schalkms
Copy link
Member Author

Yes, I can confirm that the coverage works on the local IDEA installation.

@arturbosch
Copy link
Member

Fixed by #2622

@arturbosch arturbosch added this to the 1.8.0 milestone Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants