Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide KtTestCompiler as internal #2871

Closed
arturbosch opened this issue Jul 14, 2020 · 0 comments · Fixed by #2874
Closed

Hide KtTestCompiler as internal #2871

arturbosch opened this issue Jul 14, 2020 · 0 comments · Fixed by #2874
Assignees
Milestone

Comments

@arturbosch
Copy link
Member

Expected Behavior

KtTestCompiler is an implementation detail.
It should be made internal.
Users should use compileContentForTest
createEnvironment and createPsiFactory should be accessible as top level functions.
setupKotlinEnvironment should be prefered.

Observed Behavior

KtTestCompiler is used directly.

Steps to Reproduce

  1. Try using KtTestCompiler directly in a testcase.
  2. KtCompiler cannot be found as it is from an implementation dependency of detekt-parser.

Context

Testing custom rules.
#2720 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant