Make a release built against Kotlin 1.4

[sschuberth]

Context

Kotlin 1.4 was released and we'd like to update to it, but we cannot as the compiler would issue a warning (and we break on warnings) due to detekt being built against Kotlin 1.3.72, and we cannot enforce Kotlin 1.4 due to this issue.

[arturbosch]

Getting rid of the warning will also require a new Gradle release, won't it?

Kotlin 1.4 support is on the way (#2931). Unfortunately we are blocked by pinterest/ktlint#830.

[sschuberth]

Getting rid of the warning will also require a new Gradle release, won't it?

Hmm, that triggers a good question for me: I actually don't want to enforce the Kotlin version on the Gradle / pluging classpath, but only on our app's compile classpath. So maybe the .all in

configurations.all {
    resolutionStrategy {
        // ..
    }
}

simply is too broad and affects the plugin classpath, too... I need to look into this.

[realdadfish]

Buildscript (plugin) and project classpath is separated (mostly), however, certain plugins (like e.g. the kotlin allopen plugin) might require the same Kotlin version on both classpaths.

In any case, your issue @sschuberth might be resolved by this:

  configurations.all {
        resolutionStrategy.eachDependency {
            if (requested.group == "org.jetbrains.kotlin" && requested.name == "kotlin-reflect") {
                useVersion("1.4.0")
            }
        }
    }

Most likely because some runtime dependency pulls in kotlin-reflect transitively (moshi-kotlin e.g. does it).

[sschuberth]

Thanks @realdadfish for the idea. I'm doing something similar but more detekt-specific currently, see

oss-review-toolkit/ort@6976ae0#diff-392475fdf2bc320d17762ed97109a121R176

[sschuberth]

Kotlin 1.4 support is on the way (#2931). Unfortunately we are blocked by pinterest/ktlint#830.

FYI, ktlint 0.38.0 final has just been released with the fix: https://github.com/pinterest/ktlint/releases/tag/0.38.0

[arturbosch]

Kotlin 1.4 support is on the way (#2931). Unfortunately we are blocked by pinterest/ktlint#830.

FYI, ktlint 0.38.0 final has just been released with the fix: https://github.com/pinterest/ktlint/releases/tag/0.38.0

I think we need to wait for a 0.38.1 and also build with language version = 1.3 - pinterest/ktlint#848