Skip to content

Offset calculation in KtLint deprecated/made private #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arturbosch opened this issue Aug 26, 2020 · 1 comment
Closed

Offset calculation in KtLint deprecated/made private #3021

arturbosch opened this issue Aug 26, 2020 · 1 comment
Labels
formatting help wanted improvement
Milestone
1.15.0

Comments

@arturbosch
Copy link
Member

Expected Behavior

We should probably starting duplicating the code again asap.

Current Behavior

KtLint deprecated/made the methods to calculate offsets we use in formatting private.

Context

pinterest/ktlint#857
#2760
@arturbosch arturbosch added this to the 1.13.0 milestone Aug 26, 2020
@arturbosch arturbosch removed this from the 1.13.0 milestone Sep 7, 2020
@timurt
Copy link
Contributor

timurt commented Oct 25, 2020

Hello, I want to contribute to this project as part of the Hacktoberfest event,
Can I take this issue? As far as I understood there are two deprecated methods KtLint.calculateLineColByOffset and KtLint.normalizeText , and we need to copy these methods to Detekt, am I right?

@timurt timurt mentioned this issue Oct 25, 2020
Merged
@arturbosch arturbosch added this to the 1.15.0 milestone Nov 2, 2020
arturbosch pushed a commit that referenced this issue Nov 15, 2020
@timurt @arturbosch
Duplicate deprecated KtLint methods (#3168)
68d4872 
Closes #3021
arturbosch pushed a commit that referenced this issue Dec 21, 2020
@timurt @arturbosch
Duplicate deprecated KtLint methods (#3168)
d62f27f 
Closes #3021
arturbosch pushed a commit that referenced this issue Jan 16, 2021
@timurt @arturbosch
Duplicate deprecated KtLint methods (#3168)
2458da3 
Closes #3021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
formatting help wanted improvement
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
2 participants
@timurt @arturbosch