Add ability to pass rootclasspaths to KtTestCompiler

[tyvsmith]

Expected Behavior

KtTestCompiler can take additional optional paths for loading on the root classpath for testing scenarios.

Current Behavior

Currently, KtTestCompiler allows for a test environment without specifying additional existing classes that may be needed on the root classpath.

Context

We have this change internally used for our testing environment when dealing with existing files both on the main classpath and in testing (we share EP and detekt stubs in some cases). I can upstream this if it'll be widely valuable.

Proposed Change:

internal fun createEnvironment(additionalPaths: List<File> = listOf()): KotlinCoreEnvironmentWrapper {
  val configuration = CompilerConfiguration()
  configuration.put(CommonConfigurationKeys.MODULE_NAME, "test_module")
  configuration.put(CLIConfigurationKeys.MESSAGE_COLLECTOR_KEY, MessageCollector.NONE)

  // Get the runtime location of stdlib jar and pass to the compiler so it's available to generate
  // the
  // BindingContext for rules under test.
  val path = File(CharRange::class.java.protectionDomain.codeSource.location.path)
  configuration.addJvmClasspathRoot(path)
  
  configuration.addJvmClasspathRoots(additionalPaths)

  val parentDisposable = Disposer.newDisposable()
  val kotlinCoreEnvironment =
      KotlinCoreEnvironment.createForTests(
          parentDisposable, configuration, EnvironmentConfigFiles.JVM_CONFIG_FILES)
  return KotlinCoreEnvironmentWrapper(kotlinCoreEnvironment, parentDisposable)
}

Example usage:

    val EXTRA_CLASSPATH_FILES =
        listOf(File(TestBannedMethods::class.java.protectionDomain.codeSource.location.path))

    val ENVIRONMENT = createEnvironment(EXTRA_CLASSPATH_FILES)

[schalkms]

Thanks for providing a good suggestion!
I think it’s fine to merge this function upwards, since only test environment code gets added.
Let’s wait for @arturbosch feedback.

[schalkms]

Btw sorry for the late reply. This good idea got missed somehow.

[arturbosch]

@tyvsmith yes please propose a PR. Thanks @schalkms .

[schalkms]

Closed by e52f6f2