Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassOrdering only reports first misorder, not all misorders #3141

Closed
hbmartin opened this issue Oct 10, 2020 · 1 comment
Closed

ClassOrdering only reports first misorder, not all misorders #3141

hbmartin opened this issue Oct 10, 2020 · 1 comment
Assignees
Milestone

Comments

@hbmartin
Copy link
Contributor

Expected Behavior

ClassOrdering should report all misorderings in a class

Observed Behavior

ClassOrdering only reports the first misordering in a class

Steps to Reproduce

This can be easily observed by changing a test in ClassOrderingSpec to have multiple misorders, but still pass the assertions that the list of findings only has 1 item.

Context

As a user, I expect that fixing all errors from running detekt will result in the next run succeeding. This may not be the case now, as fixing a ClassOrdering violation may reveal further violations in a subsequent run.

Your Environment

  • Version of detekt used:
  • Version of Gradle used (if applicable):
  • Operating System and version:
  • Link to your project (if it's a public repository):

@BraisGabin please assign to me

@schalkms
Copy link
Member

Closed by a714f54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants