Skip to content

"detekt" or "Detekt" #5898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3flex opened this issue Mar 12, 2023 · 15 comments · Fixed by #5953 or #5955
Closed

"detekt" or "Detekt" #5898

3flex opened this issue Mar 12, 2023 · 15 comments · Fixed by #5953 or #5955

Comments

@3flex
Copy link
Member

3flex commented Mar 12, 2023

Expected Behavior

Project refers to itself using a consistent name.

Observed Behavior

I believe detekt has been used from the beginning, but I see Detekt used more and more in documentation. We should be keeping this consistent.

Steps to Reproduce

N/A

Context

I believe @arturbosch named the project detekt with lowercase and would want it kept that way.

Your Environment

N/A

@3flex 3flex added the bug label Mar 12, 2023
@VictorIreri
Copy link

VictorIreri commented Mar 12, 2023

I agree and perhaps it could be enforced through an automated check?
I presume the increased use of "Detekt" is because capitalizing names is the norm, and so "detekt" doesn't seem quite right. So maybe styling "detekt" in a particular way across the docs might be an option to satisfy that need to make the name "feel" different. For example by italicizing detekt as we do on the configurations page, although even here it's not consistent.
https://detekt.dev/docs/introduction/configurations/

It may help to look at an example of the lowercase approach. There's a popular tool called fastlane that have done this in their docs.

@BraisGabin
Copy link
Member

Mixed feelings here:

  • If we move to Detekt everything would be just easier
  • The name of the project is detekt and that's it. I'm not sure if we should change it.

I don't know the reason behind detekt is not capitalised. But I always assumed that because it started as a cli. And as every cli it is lowercase.

So, for me, I would treat any Detekt as a typo. And, if we want to change it to Detekt we should open another issue to decide to "rename".

@BraisGabin
Copy link
Member

The lower case sometime feels strange. Examples:

When shipping the detekt Gradle Plugin[...]

Same when it goes at the start of a sentence:

detekt can be integrated into your development workflow[...]

@cortinico
Copy link
Member

I believe the name of the project should probably be lowercase.
This is also consistent with our logo:
logo

When part of another project or a plugin, I think it's fine to go for titlecase:

When shipping the detekt Gradle Plugin[...]

So this would be Detekt Gradle Plugin. The Detekt Project, The Detekt IntelliJ Plugin, etc.

@3flex
Copy link
Member Author

3flex commented Mar 15, 2023

@arturbosch there are some good considerations raised above, I'm curious what you think.

I've always thought detekt was a stylistic choice that reflects the CLI command name, and this started as a CLI tool, so that made sense. However there's now an extensive list of integrations and some people are naturally gravitating towards the capitalised version anyway.

I do think that whether it's detekt or Detekt, it should be consistent everywhere it's used.

@arturbosch
Copy link
Member

arturbosch commented Mar 15, 2023

The name is a wordplay on the verb "to detect sth." and "kt" from Kotlin.
So yes, it was intended as a lowercase detekt.
Detekt alone always looked wierd to me but Detekt Gradle Plugin looks fine.
The CLI argument sounds reasonable now but wasn't intended back then as Gradle integration was always planned.

The lower case sometime feels strange. Examples:

When shipping the detekt Gradle Plugin[...]

Same when it goes at the start of a sentence:

detekt can be integrated into your development workflow[...]

These are also valid reasons. Italic as @VictorIreri mentioned could work: detekt Gradle Plugin.
Or just using uppercase Detekt next to other uppercase names.

Btw I quite recently changed to the lowercase detekt spelling in the IJ plugin (which I could change if most maintainers want the uppercase spelling :)):

ij

@TWiStErRob
Copy link
Member

TWiStErRob commented Mar 30, 2023

The website then really needs a touch-up... 6 mentions on the home-page, and none of them are lowercase.
image
If I wanted to know which way to write it, I would stop here and conclude "Detekt" in all contexts.

Any reason why the home-home-page doesn't have the logo, @cortinico?

@cortinico
Copy link
Member

Any reason why the home-home-page doesn't have the logo, @cortinico?

The logo is there in the first block no?

Also my bad, I love uppercase and I used it everywhere. We definitely need to clean this up :) feel free to do it.

@TWiStErRob
Copy link
Member

The logo is there in the first block no?

Haha, you got me there, I mean this logo which has the name on it:

#5898 (comment)

I think the center-mid "Detekt" could be replaced with the named logo.

@TWiStErRob
Copy link
Member

Raised #5953 with some "Detekt -> detekt" changes and "Detekt Gradle Plugin" unification.

@cortinico
Copy link
Member

Haha, you got me there, I mean this logo which has the name on it:

Yeah you're right :)

@TWiStErRob
Copy link
Member

Argh, the main "logo" didn't change. It's still a screaming "Detekt" in the middle.

@TWiStErRob TWiStErRob reopened this Apr 1, 2023
@TWiStErRob
Copy link
Member

Also the title of the page. I have a feeling these are all one occurrence.
Screenshot_20230401-093748

@TWiStErRob
Copy link
Member

TWiStErRob commented Apr 1, 2023

Can someone please rename the org as well? https://github.com/detekt
Because this gives a mixed message:
image
image

@arturbosch
Copy link
Member

Can someone please rename the org as well? https://github.com/detekt Because this gives a mixed message: image image

Done, thanks for the work!

@arturbosch arturbosch added this to the 1.23.0 milestone Apr 1, 2023
@arturbosch arturbosch reopened this Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants