Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor: Disable Kotlin's incremental build support #1240

Merged
merged 1 commit into from Oct 12, 2018

Conversation

3flex
Copy link
Member

@3flex 3flex commented Oct 12, 2018

(Hopefully) fixes #1230 finally leading to reliable builds on AppVeyor.

Have now done three green AppVeyor builds with this configuration before submitting the PR (so will be 4 in a row if the PR build is OK).

Kotlin incremental compilation and Gradle daemon are now both disabled. Unlikely to have much effect on build speed (AppVeyor's build times are all over the place as it is).

Copy link
Collaborator

@Mauin Mauin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating these AppVeyor issues @3flex! Much appreciated. I also noticed the very unstable (and high) build times on AppVeyor and am looking forward to compare it to the new Windows support from Travis (which would also allow us to remove one more CI config from the repo.

@Mauin Mauin merged commit 538fd0c into detekt:master Oct 12, 2018
@3flex
Copy link
Member Author

3flex commented Oct 12, 2018

Ooh that's exciting news about Travis, looks like they already have JDK 8 & 10 preinstalled on Windows image. Moving to single CI would be great.

For now though hopefully AppVeyor is stable until Travis's Windows support matures.

@3flex 3flex deleted the patch-2 branch October 12, 2018 06:24
@Mauin
Copy link
Collaborator

Mauin commented Oct 12, 2018

Yes, let's see how stable #1241 is and once we're happy with it (and fix #1212) we could consider removing AppVeyor.

DSamaryan pushed a commit to DSamaryan/detekt that referenced this pull request Oct 18, 2018
@arturbosch arturbosch added this to the RC10 milestone Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppVeyor: w: The '-d' option with a directory destination is ignored because '-Xbuild-file' is specified
3 participants