Add naming test for ForbiddenVoid rule #1740
Conversation
This adds tests to reproduce issue #1642
| it("does not report when functions or classes are called 'Void'") { | ||
| val code = """ | ||
| class Void { | ||
| fun void() {} |
There was a problem hiding this comment.
this should be fairly easy to fix, we just check if this name is a child of a declaration?
There was a problem hiding this comment.
? What do you want to fix? There's nothing to fix here.
There was a problem hiding this comment.
Ah though this is a false positive but now seeing that the declaration name does not trigger it aka the isEmpty check :)
Codecov Report
@@ Coverage Diff @@
## master #1740 +/- ##
============================================
+ Coverage 79.78% 79.82% +0.04%
- Complexity 1933 1934 +1
============================================
Files 324 324
Lines 5456 5467 +11
Branches 1004 1006 +2
============================================
+ Hits 4353 4364 +11
Misses 581 581
Partials 522 522
Continue to review full report at Codecov.
|
|
I don't know what problem CodeFactor has. There's no trailing whitespace there. |
|
Not even in the testing code? It look wierd at github though. |
This adds tests to reproduce issue #1642