Skip to content

Update EmptyClassBlock to skip classes with comments in the body#1758

Merged
arturbosch merged 3 commits intodetekt:masterfrom
cortinico:fix-1756-empty-class-block
Jul 12, 2019
Merged

Update EmptyClassBlock to skip classes with comments in the body#1758
arturbosch merged 3 commits intodetekt:masterfrom
cortinico:fix-1756-empty-class-block

Conversation

@cortinico
Copy link
Copy Markdown
Member

This is similar to #1690 but I'm fixing the EmptyClassBlock rule here

Fixes #1756

Copy link
Copy Markdown
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arturbosch arturbosch added this to the 1.0.0 milestone Jul 6, 2019
@arturbosch arturbosch merged commit d018371 into detekt:master Jul 12, 2019
@cortinico cortinico deleted the fix-1756-empty-class-block branch June 13, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EmptyClassBlock should consider comment as "body" (via option?)

3 participants