Fix missing report file issue. #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 11, 2019 18:23
Consolidation may only be triggered for the 'old' detekt task because they are configured to depend on the detekt tasks of all subprojects. For tasks with type resolution such as detektMain this is not the case.
Since the kotlin plugin is very likely to be present in projects using detekt and since we use it to add tasks for source sets we should use it in all tests as well. Add stdlib to test project dependencies as the check task automatically builds the sources if kotlin plugin is present.
The goal is to write a test case only once and run it with groovy and kotlin dsl.
|
How does your PR differ from #1763 ? |
|
The effect is in most cases going to be the same. I could imagine that with #1763 if you run |
arturbosch
approved these changes
Jul 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1757 and closes #1685
Consolidation may only be triggered for the 'old' detekt task because they are configured to depend on the detekt tasks of all subprojects. For tasks with type resolution such as detektMain this is not the case.
The issue was not detected in the tests because we did not use the kotlin gradle plugin in the integration tests.