Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Complex Method doc - closes #1009 #1773

Merged
merged 2 commits into from
Jul 28, 2019
Merged

Update Complex Method doc - closes #1009 #1773

merged 2 commits into from
Jul 28, 2019

Conversation

schalkms
Copy link
Member

No description provided.

Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!
I guess we should add a configuration option to exclude scope functions, what do you think?

@arturbosch arturbosch added this to the 1.0.0 milestone Jul 27, 2019
Copy link
Member Author

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arturbosch I'm not sure. This scope functions certainly introduce another path through the application. That's why I'd for now leave as it is.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@80be66d). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1773   +/-   ##
=========================================
  Coverage          ?   79.82%           
  Complexity        ?     1937           
=========================================
  Files             ?      324           
  Lines             ?     5472           
  Branches          ?     1009           
=========================================
  Hits              ?     4368           
  Misses            ?      581           
  Partials          ?      523
Impacted Files Coverage Δ Complexity Δ
...rturbosch/detekt/rules/complexity/ComplexMethod.kt 96.29% <ø> (ø) 11 <0> (?)
...ab/arturbosch/detekt/api/internal/McCabeVisitor.kt 91.42% <100%> (ø) 18 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80be66d...0118edc. Read the comment docs.

@arturbosch arturbosch merged commit ce24828 into detekt:master Jul 28, 2019
@schalkms schalkms deleted the doc-ComplexMethod-#1009 branch August 9, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants