Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy the build files #1814

Merged
merged 8 commits into from
Aug 13, 2019
Merged

Tidy the build files #1814

merged 8 commits into from
Aug 13, 2019

Conversation

3flex
Copy link
Member

@3flex 3flex commented Aug 11, 2019

Just for fun I went through the build files to look for possible improvements - this should make them a little bit clearer and performant.

jcenter()
maven(url = "https://dl.bintray.com/arturbosch/generic")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove both maven instructions? Is this not necessary anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build won't succeed if repositories are required that are removed. The bintray line was there because there used to be a dependency on ksh library (from memory) which is no longer used.

mavenLocal would have supported local testing of the Gradle plugin but with composite builds that's not necessary anymore.

Currently not all dependencies are available on Maven Central otherwise would use that instead of jcenter.

@@ -139,7 +138,7 @@ subprojects {
}
}

tasks.withType<Test> {
tasks.withType<Test>().configureEach {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does lazy configuration?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lazy configuration and task configuration avoidance are two different things. This is task configuration avoidance (tasks are configured on demand).

https://docs.gradle.org/current/userguide/task_configuration_avoidance.html

developer.appendNode("email", "arturbosch@gmx.de")

appendNode("scm").appendNode("url", "https://github.com/arturbosch/detekt")
pom {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer :)

@arturbosch arturbosch merged commit aabbcd8 into detekt:master Aug 13, 2019
@arturbosch arturbosch added this to the 1.0.1 milestone Aug 14, 2019
@3flex 3flex deleted the tidy branch August 24, 2019 04:10
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Remove explicit dependency on compiler-embeddable

* Remove unnneeded task dependency

* Tidy up setting the Bintray user/pass

* Use type-safe accessors where possible

* Use tidy syntax

* Remove unused lines

* Remove unused repositories

* Avoid task configuration
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Remove explicit dependency on compiler-embeddable

* Remove unnneeded task dependency

* Tidy up setting the Bintray user/pass

* Use type-safe accessors where possible

* Use tidy syntax

* Remove unused lines

* Remove unused repositories

* Avoid task configuration
@3flex 3flex restored the tidy branch July 29, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants