-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy the build files #1814
Tidy the build files #1814
Conversation
jcenter() | ||
maven(url = "https://dl.bintray.com/arturbosch/generic") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove both maven
instructions? Is this not necessary anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build won't succeed if repositories are required that are removed. The bintray line was there because there used to be a dependency on ksh library (from memory) which is no longer used.
mavenLocal would have supported local testing of the Gradle plugin but with composite builds that's not necessary anymore.
Currently not all dependencies are available on Maven Central otherwise would use that instead of jcenter.
@@ -139,7 +138,7 @@ subprojects { | |||
} | |||
} | |||
|
|||
tasks.withType<Test> { | |||
tasks.withType<Test>().configureEach { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does lazy configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lazy configuration and task configuration avoidance are two different things. This is task configuration avoidance (tasks are configured on demand).
https://docs.gradle.org/current/userguide/task_configuration_avoidance.html
developer.appendNode("email", "arturbosch@gmx.de") | ||
|
||
appendNode("scm").appendNode("url", "https://github.com/arturbosch/detekt") | ||
pom { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer :)
* Remove explicit dependency on compiler-embeddable * Remove unnneeded task dependency * Tidy up setting the Bintray user/pass * Use type-safe accessors where possible * Use tidy syntax * Remove unused lines * Remove unused repositories * Avoid task configuration
* Remove explicit dependency on compiler-embeddable * Remove unnneeded task dependency * Tidy up setting the Bintray user/pass * Use type-safe accessors where possible * Use tidy syntax * Remove unused lines * Remove unused repositories * Avoid task configuration
Just for fun I went through the build files to look for possible improvements - this should make them a little bit clearer and performant.