Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write guide on how to make detekt silent #1819

Merged
merged 2 commits into from
Aug 17, 2019
Merged

Write guide on how to make detekt silent #1819

merged 2 commits into from
Aug 17, 2019

Conversation

arturbosch
Copy link
Member

No description provided.

@arturbosch arturbosch added this to the 1.0.1 milestone Aug 14, 2019
schalkms
schalkms reviewed Aug 15, 2019
View reviewed changes
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!
I think the blog posts are badly placed on the homepage.
In my opinion they should have a more prominent place.

docs/_posts/2019-08-14-custom-console-reports.md Outdated Show resolved Hide resolved
docs/_posts/2019-08-14-custom-console-reports.md Outdated Show resolved Hide resolved
docs/_posts/2019-08-14-custom-console-reports.md Outdated Show resolved Hide resolved
docs/_posts/2019-08-14-custom-console-reports.md Outdated Show resolved Hide resolved
docs/_posts/2019-08-14-custom-console-reports.md Outdated Show resolved Hide resolved
@arturbosch
Copy link
Member Author

arturbosch commented Aug 15, 2019 •
edited
Loading

Your right.
We could

  1. split news and guides, introducing a new navigation item called guides next to news.
  2. Just link the guides tag in the readme https://arturbosch.github.io/detekt/tag_guides.html
  3. Rename news to blog and link it with news/guides tags in the readme

@schalkms @3flex

@codecov-io
Copy link

Codecov Report

Merging #1819 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1819   +/-   ##
=========================================
  Coverage     79.75%   79.75%           
  Complexity     1932     1932           
=========================================
  Files           323      323           
  Lines          5497     5497           
  Branches       1019     1019           
=========================================
  Hits           4384     4384           
  Misses          589      589           
  Partials        524      524

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c22b1b...c7d2fc1. Read the comment docs.

@arturbosch arturbosch merged commit 76431b4 into master Aug 17, 2019
@arturbosch arturbosch deleted the silent-detekt branch August 17, 2019 11:56
@TWiStErRob TWiStErRob mentioned this pull request Aug 18, 2019
Closed
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
@arturbosch @smyachenkov
Write guide on how to make detekt silent (detekt#1819)
7584d1c 
* Write guide on how to make detekt silent

* Correct grammar
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
@arturbosch
Write guide on how to make detekt silent (detekt#1819)
df225fe 
* Write guide on how to make detekt silent

* Correct grammar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkms schalkms schalkms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@arturbosch @codecov-io @schalkms