Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ComplexInterface test cases to JSR223 #1830

Merged
merged 2 commits into from
Aug 23, 2019
Merged

Migrate ComplexInterface test cases to JSR223 #1830

merged 2 commits into from
Aug 23, 2019

Conversation

schalkms
Copy link
Member

@schalkms schalkms commented Aug 19, 2019

ref #1828

Copy link
Member Author

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arturbosch can you please deactivate the detekt.TrailingWhitespace rule on codefactor?

@arturbosch
Copy link
Member

Unfortunately we can't deactivate it there. It just tells us that it uses our config/detekt/config.yml file...
Idk what is happening there and why it is not the same as our CI detekt findings ...

@arturbosch arturbosch added this to the 1.0.1 milestone Aug 23, 2019
@arturbosch arturbosch merged commit 48aaa36 into detekt:master Aug 23, 2019
@schalkms schalkms deleted the #1828-test-cases branch August 31, 2019 11:00
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Migrate ComplexInterface test cases to JSR223

* Fix detekt.TrailingWhitespace warnings
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Migrate ComplexInterface test cases to JSR223

* Fix detekt.TrailingWhitespace warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants