-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't build twice when PR created from branch #1866
Conversation
Closing and reopening to try and get Codecov to respond with a coverage report... Report can be seen on codecov.io but comment notification didn't fire. Possibly related: https://community.codecov.io/t/github-bot-doesnt-report-pr/494 |
I don't think this is blocked? Codecov reports are not reliable, so not getting those is somewhat expected. |
@3flex Shall I merge this then? |
I know. I also invested too many hours for investigating codecov's strange behavior when generating reports. |
It's also not the end of the world if codecov doesn't always add a comment to a PR. |
I think so, but would like Artur to review as well. This only affects repository owners & collaborators since CI will not run on branches in arturbosch/detekt repository anymore, only when the PR is created. I don't want to ruin his workflow! |
* Skip branch with PR on AppVeyor * Only build master branch on Travis
* Skip branch with PR on AppVeyor * Only build master branch on Travis
* Skip branch with PR on AppVeyor * Only build master branch on Travis
* Skip branch with PR on AppVeyor * Only build master branch on Travis
This speeds build time when a PR is created from a branch in the detekt repo.
Currently both Travis and AppVeyor run CI checks on the branch which has commits pushed to it as well as the PR that is created from that branch.
This config changes that for both Travis and AppVeyor so CI should only run on master branch and any submitted PRs, but not on other branches in detekt repo. This saves time in CI.