Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build twice when PR created from branch #1866

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Conversation

3flex
Copy link
Member

@3flex 3flex commented Aug 30, 2019

This speeds build time when a PR is created from a branch in the detekt repo.

Currently both Travis and AppVeyor run CI checks on the branch which has commits pushed to it as well as the PR that is created from that branch.

This config changes that for both Travis and AppVeyor so CI should only run on master branch and any submitted PRs, but not on other branches in detekt repo. This saves time in CI.

@3flex
Copy link
Member Author

3flex commented Aug 30, 2019

Closing and reopening to try and get Codecov to respond with a coverage report... Report can be seen on codecov.io but comment notification didn't fire.

Possibly related: https://community.codecov.io/t/github-bot-doesnt-report-pr/494

@3flex 3flex closed this Aug 30, 2019
@3flex 3flex reopened this Aug 30, 2019
@3flex
Copy link
Member Author

3flex commented Aug 30, 2019

I don't think this is blocked? Codecov reports are not reliable, so not getting those is somewhat expected.

@schalkms schalkms removed the blocked label Aug 30, 2019
@schalkms
Copy link
Member

@3flex Shall I merge this then?

@schalkms
Copy link
Member

Codecov reports are not reliable, so not getting those is somewhat expected.

I know. I also invested too many hours for investigating codecov's strange behavior when generating reports.

@schalkms
Copy link
Member

Report can be seen on codecov.io but comment notification didn't fire.

It's also not the end of the world if codecov doesn't always add a comment to a PR.
I'm happy if codecov reports at least a reasonable code coverage and doesn't spill this weird and cryptic error messages, where you don't actually know why.

@3flex
Copy link
Member Author

3flex commented Aug 30, 2019

Shall I merge this then?

I think so, but would like Artur to review as well. This only affects repository owners & collaborators since CI will not run on branches in arturbosch/detekt repository anymore, only when the PR is created. I don't want to ruin his workflow!

@3flex 3flex requested a review from arturbosch August 30, 2019 10:29
@arturbosch arturbosch merged commit 9f100e2 into master Sep 12, 2019
@arturbosch arturbosch deleted the no-double-builds branch September 12, 2019 21:23
@arturbosch arturbosch added this to the 1.0.2 milestone Sep 12, 2019
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 17, 2019
* Skip branch with PR on AppVeyor

* Only build master branch on Travis
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 17, 2019
* Skip branch with PR on AppVeyor

* Only build master branch on Travis
@arturbosch arturbosch modified the milestones: 1.0.2, 1.1.0 Sep 17, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Skip branch with PR on AppVeyor

* Only build master branch on Travis
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Skip branch with PR on AppVeyor

* Only build master branch on Travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants