Skip to content

Replace tabs with spaces in rule KDoc #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2019
Merged

Replace tabs with spaces in rule KDoc #1876

merged 1 commit into from
Aug 31, 2019

Conversation

schalkms
Copy link
Member

The parsed [KDocSection] element contains no tabs.
Therefore, the indentation gets removed when generating the Markdown
rule documentation out of the rules KDoc.
This PR fixes #1871.

The parsed [KDocSection] element contains no tabs.
Therefore, the indentation gets removed when generating the Markdown
rule documentation out of the rules KDoc.
This PR fixes #1871.
@codecov-io
Copy link

codecov-io commented Aug 31, 2019

Codecov Report

Merging #1876 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1876   +/-   ##
=========================================
  Coverage     80.31%   80.31%           
  Complexity     1958     1958           
=========================================
  Files           325      325           
  Lines          5517     5517           
  Branches       1025     1025           
=========================================
  Hits           4431     4431           
  Misses          557      557           
  Partials        529      529
Impacted Files Coverage Δ Complexity Δ
...rbosch/detekt/rules/style/EqualsOnSignatureLine.kt 88.88% <ø> (ø) 6 <0> (ø) ⬇️
...tekt/rules/exceptions/TooGenericExceptionCaught.kt 86.95% <ø> (ø) 5 <0> (ø) ⬇️
...tekt/rules/exceptions/TooGenericExceptionThrown.kt 92.85% <ø> (ø) 4 <0> (ø) ⬇️
...ch/detekt/rules/style/ExplicitItLambdaParameter.kt 100% <ø> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f51ecfc...00737e8. Read the comment docs.

@3flex 3flex merged commit 9070b81 into detekt:master Aug 31, 2019
@schalkms schalkms deleted the fix-#1871 branch September 1, 2019 08:32
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 2, 2019
The parsed [KDocSection] element contains no tabs.
Therefore, the indentation gets removed when generating the Markdown
rule documentation out of the rules KDoc.
This PR fixes detekt#1871.
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 2, 2019
The parsed [KDocSection] element contains no tabs.
Therefore, the indentation gets removed when generating the Markdown
rule documentation out of the rules KDoc.
This PR fixes detekt#1871.
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 2, 2019
The parsed [KDocSection] element contains no tabs.
Therefore, the indentation gets removed when generating the Markdown
rule documentation out of the rules KDoc.
This PR fixes detekt#1871.
@arturbosch arturbosch added this to the 1.0.2 milestone Sep 6, 2019
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 17, 2019
The parsed [KDocSection] element contains no tabs.
Therefore, the indentation gets removed when generating the Markdown
rule documentation out of the rules KDoc.
This PR fixes detekt#1871.
@arturbosch arturbosch modified the milestones: 1.0.2, 1.1.0 Sep 17, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
The parsed [KDocSection] element contains no tabs.
Therefore, the indentation gets removed when generating the Markdown
rule documentation out of the rules KDoc.
This PR fixes detekt#1871.
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
The parsed [KDocSection] element contains no tabs.
Therefore, the indentation gets removed when generating the Markdown
rule documentation out of the rules KDoc.
This PR fixes detekt#1871.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indentation for compliant and non-compliant code examples is missing
4 participants