Minimise usage of Kotlin reflection #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3flex
force-pushed
the
less-reflection
branch
from
b2321a5 to
771a4df
Compare
schalkms
approved these changes
Sep 3, 2019
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 4, 2019
* Remove kotlin-reflect usage in detekt-rules * detekt-gradle-plugin doesn't use Kotlin reflection * detekt-rules needs kotlin-reflect for tests * Remove more class references * Function should remain internal
arturbosch
reviewed
Sep 6, 2019
|
|
||
| /** | ||
| * Tests if this element is part of given PsiElement. | ||
| */ | ||
| fun PsiElement.isPartOf(clazz: KClass<out PsiElement>): Boolean = getNonStrictParentOfType(clazz.java) != null | ||
| inline fun <reified T : PsiElement> PsiElement.isPartOf() = getNonStrictParentOfType<T>() != null |
There was a problem hiding this comment.
Interesting, I remember that I had to rewrite some psi helpers because the kotlin compiler throw errors because he could not resolve all types or something ...
|
Just out of curiosity, what was the reasoning for this changes? I see the code is now much more readable :). |
That was the only reason :) I hope it doesn't reintroduce any bugs. |
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
* Remove kotlin-reflect usage in detekt-rules * detekt-gradle-plugin doesn't use Kotlin reflection * detekt-rules needs kotlin-reflect for tests * Remove more class references * Function should remain internal
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Remove kotlin-reflect usage in detekt-rules * detekt-gradle-plugin doesn't use Kotlin reflection * detekt-rules needs kotlin-reflect for tests * Remove more class references * Function should remain internal
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Remove kotlin-reflect usage in detekt-rules * detekt-gradle-plugin doesn't use Kotlin reflection * detekt-rules needs kotlin-reflect for tests * Remove more class references * Function should remain internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining usage is in detekt-api (KClass is used in a public API, and there are some property delegates which require it).