-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only report UnsafeCallOnNullableType on actual nullable types #1886
Conversation
...rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/UnsafeCallOnNullableTypeSpec.kt
Outdated
Show resolved
Hide resolved
...rules/src/test/kotlin/io/gitlab/arturbosch/detekt/rules/bugs/UnsafeCallOnNullableTypeSpec.kt
Outdated
Show resolved
Hide resolved
Blocked by #1880 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late merge of #1880
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
============================================
- Coverage 80.45% 80.42% -0.03%
- Complexity 1968 1969 +1
============================================
Files 326 326
Lines 5510 5513 +3
Branches 1022 1025 +3
============================================
+ Hits 4433 4434 +1
Misses 543 543
- Partials 534 536 +2
Continue to review full report at Codecov.
|
…#1886) * Only check !! used on nullable types * Use more appropriate method to get a type
…#1886) * Only check !! used on nullable types * Use more appropriate method to get a type
…#1886) * Only check !! used on nullable types * Use more appropriate method to get a type
…#1886) * Only check !! used on nullable types * Use more appropriate method to get a type
Fixes #880
Rule now requires type resolution.