Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only report UnsafeCallOnNullableType on actual nullable types #1886

Merged
merged 2 commits into from
Sep 13, 2019

Conversation

3flex
Copy link
Member

@3flex 3flex commented Sep 1, 2019

Fixes #880

Rule now requires type resolution.

@3flex
Copy link
Member Author

3flex commented Sep 2, 2019

Blocked by #1880

@3flex 3flex added the blocked label Sep 2, 2019
Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late merge of #1880

@arturbosch arturbosch added this to the 1.0.2 milestone Sep 12, 2019
@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #1886 into master will decrease coverage by 0.02%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1886      +/-   ##
============================================
- Coverage     80.45%   80.42%   -0.03%     
- Complexity     1968     1969       +1     
============================================
  Files           326      326              
  Lines          5510     5513       +3     
  Branches       1022     1025       +3     
============================================
+ Hits           4433     4434       +1     
  Misses          543      543              
- Partials        534      536       +2
Impacted Files Coverage Δ Complexity Δ
...rturbosch/detekt/rules/bugs/RedundantElseInWhen.kt 72.22% <0%> (ø) 9 <0> (ø) ⬇️
...ab/arturbosch/detekt/rules/bugs/MissingWhenCase.kt 93.1% <100%> (ø) 13 <0> (ø) ⬇️
...osch/detekt/rules/bugs/UnsafeCallOnNullableType.kt 72.72% <33.33%> (-14.78%) 4 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f714f6e...6f34bdd. Read the comment docs.

@schalkms schalkms merged commit f80fe60 into detekt:master Sep 13, 2019
@3flex 3flex deleted the 880-fix branch September 13, 2019 22:25
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 17, 2019
…#1886)

* Only check !! used on nullable types

* Use more appropriate method to get a type
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 17, 2019
…#1886)

* Only check !! used on nullable types

* Use more appropriate method to get a type
@arturbosch arturbosch modified the milestones: 1.0.2, 1.1.0 Sep 17, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
…#1886)

* Only check !! used on nullable types

* Use more appropriate method to get a type
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
…#1886)

* Only check !! used on nullable types

* Use more appropriate method to get a type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnsafeCallOnNullableType should not be reported for platform types
4 participants