Update detekt extensions doc #1893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1864 The old extensions documentation included deprecated code samples. This deprecated code samples were replaced with the code in the detekt-extension project.
Codecov Report
@@ Coverage Diff @@
## master #1893 +/- ##
============================================
+ Coverage 80.24% 80.25% +0.01%
- Complexity 1947 1951 +4
============================================
Files 325 325
Lines 5503 5511 +8
Branches 1018 1020 +2
============================================
+ Hits 4416 4423 +7
Misses 557 557
- Partials 530 531 +1
Continue to review full report at Codecov.
|
cortinico
requested changes
Sep 3, 2019
| @@ -48,23 +50,25 @@ class TooManyFunctions : Rule("TooManyFunctions") { | |||
|
|
|||
| Example of a much preciser rule in terms of more specific CodeSmell constructor and Rule attributes: | |||
| ```kotlin | |||
| class TooManyFunctions2(config: Config) : | |||
| Rule("TooManyFunctionsTwo", Severity.Maintainability, config) { | |||
| class TooManyFunctions2(config: Config) : ThresholdRule(config, THRESHOLD) { | |||
There was a problem hiding this comment.
You probably forgot to copy over:
const val THRESHOLD = 10
Co-Authored-By: Nicola Corti <corti.nico@gmail.com>
arturbosch
approved these changes
Sep 6, 2019
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
* Update detekt extensions doc Closes detekt#1864 The old extensions documentation included deprecated code samples. This deprecated code samples were replaced with the code in the detekt-extension project. * Apply suggestions from code review Co-Authored-By: Nicola Corti <corti.nico@gmail.com> * Add THRESHOLD constant to code sample
sowmyav24
pushed a commit
to sowmyav24/detekt
that referenced
this pull request
Sep 17, 2019
* Update detekt extensions doc Closes detekt#1864 The old extensions documentation included deprecated code samples. This deprecated code samples were replaced with the code in the detekt-extension project. * Apply suggestions from code review Co-Authored-By: Nicola Corti <corti.nico@gmail.com> * Add THRESHOLD constant to code sample
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Update detekt extensions doc Closes detekt#1864 The old extensions documentation included deprecated code samples. This deprecated code samples were replaced with the code in the detekt-extension project. * Apply suggestions from code review Co-Authored-By: Nicola Corti <corti.nico@gmail.com> * Add THRESHOLD constant to code sample
smyachenkov
pushed a commit
to smyachenkov/detekt
that referenced
this pull request
Dec 9, 2019
* Update detekt extensions doc Closes detekt#1864 The old extensions documentation included deprecated code samples. This deprecated code samples were replaced with the code in the detekt-extension project. * Apply suggestions from code review Co-Authored-By: Nicola Corti <corti.nico@gmail.com> * Add THRESHOLD constant to code sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1864
The old extensions documentation included deprecated code samples.
This deprecated code samples were replaced with the code in the
detekt-extension project.