Fix shared variable in detekt-extension rules #1897
Conversation
| @@ -40,6 +40,7 @@ class TooManyFunctionsTwo(config: Config) : ThresholdRule(config, THRESHOLD) { | |||
| references = emptyList()) | |||
| ) | |||
| } | |||
| amount = 0 | |||
There was a problem hiding this comment.
Do we really need two example rules that basically do the same?
There was a problem hiding this comment.
Maybe it's to demonstrate how the rule provider works when registering multiple rules (one with, one without custom config)? But maybe removing the second example and just adding a comment to SampleProvider is enough.
They don't require much maintenance though so we could just leave it.
There was a problem hiding this comment.
That exactly was the intention. One can be configured, the other not. One reports ThresholdedCodeSmell other just CodeSmell.
Codecov Report
@@ Coverage Diff @@
## master #1897 +/- ##
=========================================
Coverage 80.25% 80.25%
Complexity 1949 1949
=========================================
Files 325 325
Lines 5504 5504
Branches 1019 1019
=========================================
Hits 4417 4417
Misses 557 557
Partials 530 530Continue to review full report at Codecov.
|
| @@ -40,6 +40,7 @@ class TooManyFunctionsTwo(config: Config) : ThresholdRule(config, THRESHOLD) { | |||
| references = emptyList()) | |||
| ) | |||
| } | |||
| amount = 0 | |||
There was a problem hiding this comment.
That exactly was the intention. One can be configured, the other not. One reports ThresholdedCodeSmell other just CodeSmell.
* Fix shared variable in detekt-extension rules * Use KtFile instead of PsiFile visitor
* Fix shared variable in detekt-extension rules * Use KtFile instead of PsiFile visitor
* Fix shared variable in detekt-extension rules * Use KtFile instead of PsiFile visitor
* Fix shared variable in detekt-extension rules * Use KtFile instead of PsiFile visitor
No description provided.