Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 6 #1902

Merged
merged 8 commits into from
Nov 25, 2019
Merged

Gradle 6 #1902

merged 8 commits into from
Nov 25, 2019

Conversation

3flex
Copy link
Member

@3flex 3flex commented Sep 8, 2019

See #1820 for background.

Gradle 5.0 is now the lowest compatible version (not easy or perhaps even possible to support 4.x and 6.x at the same time).

Fixes #2040

@arturbosch
Copy link
Member

Gradle 5.0 is from Dezember 2018. I'm okay with having it as the minimum supported version ^^ 👍

@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #1902 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1902   +/-   ##
=========================================
  Coverage     80.62%   80.62%           
  Complexity     2015     2015           
=========================================
  Files           336      336           
  Lines          5802     5802           
  Branches       1057     1057           
=========================================
  Hits           4678     4678           
  Misses          563      563           
  Partials        561      561

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39fd293...c627834. Read the comment docs.

@3flex 3flex force-pushed the gradle6 branch 3 times, most recently from 6768d06 to cbab3d0 Compare September 15, 2019 12:51
@arturbosch
Copy link
Member

So version 6 will be the next Gradle release this month.
Lets release a version 1.1 with Gradle 4.10 support and merge this for 1.2 preparations @schalkms @3flex

@arturbosch arturbosch marked this pull request as ready for review September 16, 2019 08:03
@3flex
Copy link
Member Author

3flex commented Sep 16, 2019

Yep, no rush on this. In fact I wouldn't want to merge this until 6.0 stable is out - there might be more changes or deprecations to be made to the current version of the plugin first.

@arturbosch
Copy link
Member

This PR is not affected by the build failure at master.

@3flex 3flex force-pushed the gradle6 branch 2 times, most recently from ca25862 to d329800 Compare October 24, 2019 12:48
@3flex 3flex changed the title Gradle 6 [WIP] Gradle 6 Oct 29, 2019
@arturbosch arturbosch removed this from the 1.2.0 milestone Nov 5, 2019
@3flex 3flex force-pushed the gradle6 branch 2 times, most recently from 799700e to 7312c6e Compare November 20, 2019 11:40
@3flex 3flex changed the title [WIP] Gradle 6 Gradle 6 Nov 21, 2019
@3flex 3flex requested review from arturbosch and schalkms November 21, 2019 01:41
Copy link
Member

@schalkms schalkms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@arturbosch arturbosch merged commit b75cf42 into detekt:master Nov 25, 2019
@arturbosch
Copy link
Member

🥇

@arturbosch arturbosch modified the milestones: 1.2.0, 1.3.0 Nov 25, 2019
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Gradle 6

* Remove ProjectLayout.fileProperty usage

Removed in Gradle 6

* Remove deprecated inputs

* Fix validateTaskProperties issues

* Remove unnecessary extension

* Use new plugin validation task name

* Simplify docs
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
* Gradle 6

* Remove ProjectLayout.fileProperty usage

Removed in Gradle 6

* Remove deprecated inputs

* Fix validateTaskProperties issues

* Remove unnecessary extension

* Use new plugin validation task name

* Simplify docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Gradle 6.0-rc-1
4 participants