Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail on master when test coverage decreases #1914

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Don't fail on master when test coverage decreases #1914

merged 1 commit into from
Sep 16, 2019

Conversation

schalkms
Copy link
Member

The build on master shouldn't fail if the test coverage drops slightly.
See commit: 7187493

@schalkms
Don't fail on master when test coverage decreases
764d2d6 
The build on master shouldn't fail if the test coverage drops slightly.
See commit: 7187493
@arturbosch
Copy link
Member

What's the reasoning behind reopening this?
Due to not writing duplicated tests for BindingContext.empty?

@schalkms
Copy link
Member Author

I didn't reopen the PR. I created a new one with a different codecov configuration.
Let's say we want to merge a PR, where the code coverage slightly goes down, into master.
This happened in 7187493. The build in the feature branch failed, because the code coverage went down. However, we don't want to fail the build on master too, if we decide to merge this feature branch resulting in a slightly lower coverage.

@arturbosch arturbosch merged commit ee93bf7 into detekt:master Sep 16, 2019
@arturbosch arturbosch added this to the 1.0.2 milestone Sep 16, 2019
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 17, 2019
@schalkms @sowmyav24
Don't fail on master when test coverage decreases (detekt#1914)
7b1ddab 
The build on master shouldn't fail if the test coverage drops slightly.
See commit: 7187493
sowmyav24 pushed a commit to sowmyav24/detekt that referenced this pull request Sep 17, 2019
@schalkms @sowmyav24
Don't fail on master when test coverage decreases (detekt#1914)
39d25a1 
The build on master shouldn't fail if the test coverage drops slightly.
See commit: 7187493
@arturbosch arturbosch modified the milestones: 1.0.2, 1.1.0 Sep 17, 2019
@schalkms schalkms deleted the codecov-fail branch November 8, 2019 18:11
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
@schalkms @smyachenkov
Don't fail on master when test coverage decreases (detekt#1914)
2813eff 
The build on master shouldn't fail if the test coverage drops slightly.
See commit: 7187493
smyachenkov pushed a commit to smyachenkov/detekt that referenced this pull request Dec 9, 2019
@schalkms
Don't fail on master when test coverage decreases (detekt#1914)
904380e 
The build on master shouldn't fail if the test coverage drops slightly.
See commit: 7187493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@schalkms @arturbosch